Bug 63447 - PropertiesChunk.writeProperties: do not write ASCII_STRING properties as UNICODE_STRING
Summary: PropertiesChunk.writeProperties: do not write ASCII_STRING properties as UNIC...
Status: NEW
Alias: None
Product: POI
Classification: Unclassified
Component: HSMF (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-17 09:57 UTC by Dominik Hölzl
Modified: 2019-05-17 12:25 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Hölzl 2019-05-17 09:57:50 UTC 
PropertiesChunk.writeProperties: ASCII_STRING properties must be written as ASCII_STRING properties but not UNICODE_STRING as written raw value (PropertyValue.getRawValue) is formatted as ASCII_STRING.

Without this fix writing a MSG with ASCII strings causes the strings to be written with UNICODE type information but ASCII string content which causes the ASCII strings interpreted as UNICODE when re-opened.

See

https://github.com/apache/poi/pull/146
Comment 1 PJ Fanning 2019-05-17 12:25:46 UTC 
Change looks ok to me - but it would be good if someone who knows more about the old H**F formats could also review this.