Bug 63910 - Broken maven poms in released 5.2 version
Summary: Broken maven poms in released 5.2 version
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 5.2
Hardware: All All
: P2 blocker (vote)
Target Milestone: JMETER_5.2.1
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-09 10:34 UTC by Philippe Mouawad
Modified: 2019-11-11 17:48 UTC (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2019-11-09 10:34:36 UTC
Hello,We have an issue with generated poms:
1/ Unspecified version in ApacheJMeter_core for jorphan:
https://repo1.maven.org/maven2/org/apache/jmeter/ApacheJMeter_core/5.2/ApacheJMeter_core-5.2.pom
We have this:<dependency><groupId>org.apache.jmeter</groupId><artifactId>jorphan</artifactId><version>unspecified</version></dependency>

2/ The other poms are wrong.Previously all modules inherited from ApacheJMeter_parent . ApacheJMeter_parent pom has not been released and other modules do not reference it anymore anyway nor do they mention mandatory dependencies.

So this is a big problem for maven dependent projects
Can it be fixed without releasing a 5.2.1 ?

Regards
Philippe
Comment 1 Philippe Mouawad 2019-11-09 21:32:02 UTC
vladimirsitnikov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git

commit ef06709a780bc776ecc3b5d839c424d39bb1aeae
Author: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
AuthorDate: Sat Nov 9 18:53:59 2019 +0300

    Specify versions for all Gradle projects

    Even though "projects without versions" might work,
    it seems to be an edge case (e.g. generated pom.xml might contain version=unspecified)

    So we specify versions for all the modules, and trim that version from file names when
    generating release artifacts.
---
 .travis.yml               |  3 +++
 build.gradle.kts          |  1 +
 src/dist/build.gradle.kts | 26 ++++++++++++++++++--------
 3 files changed, 22 insertions(+), 8 deletions(-)



pmouawad pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git


The following commit(s) were added to refs/heads/master by this push:
     new f05baec  build.gradle.kts in core,functions,components,protocol: Fix dependencies for pom generation and remove version
f05baec is described below

commit f05baec58fa278479108c2929e622a5b8cfe2157
Author: pmouawad <p.mouawad@ubik-ingenierie.com>
AuthorDate: Sat Nov 9 22:17:22 2019 +0100

    build.gradle.kts in core,functions,components,protocol: Fix dependencies
    for pom generation and remove version
---
 src/components/build.gradle.kts |  5 ++++-
 src/core/build.gradle.kts       |  2 ++
 src/functions/build.gradle.kts  |  6 +++---
 src/protocol/build.gradle.kts   | 24 +++++++++++++-----------
 4 files changed, 22 insertions(+), 15 deletions(-)