Bug 64067 - Allow more than one parameter when defining RewriteMaps
Summary: Allow more than one parameter when defining RewriteMaps
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 9
Classification: Unclassified
Component: Catalina (show other bugs)
Version: unspecified
Hardware: All All
: P2 enhancement (vote)
Target Milestone: -----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-09 17:19 UTC by Felix Schumacher
Modified: 2020-01-09 17:36 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Schumacher 2020-01-09 17:19:10 UTC 
The current implementation of configuring RewriteMaps allows only one parameter that must not contain spaces.

It would be nice to support more than one parameter and enable parameters to contain spaces.

With such an enhancement a definition of a RewriteMap could be done like the following example

RewriteMap tc example.TimeConvert UTC "CET"

Where the second quotes could be left out as they don't guard space characters.
Comment 1 Felix Schumacher 2020-01-09 17:36:30 UTC 
commit b978b2c83ffe1be0670f47ccab0cbfaebdaba694
AuthorDate: Fri Nov 1 16:52:52 2019 +0100

    Allow more quoted tokens for RewriteValve config
    
    Along with quoted token parsing, RewriteMaps can have more than one
    parameter now.
    
    Bugzilla Id: 64067
    Part of #221
---
 .../valves/rewrite/QuotedStringTokenizer.java      | 135 +++++++++++++++++++++
 .../apache/catalina/valves/rewrite/RewriteMap.java |  18 +++
 .../catalina/valves/rewrite/RewriteValve.java      |   2 +-
 .../valves/rewrite/TestQuotedStringTokenizer.java  |  71 +++++++++++
 webapps/docs/changelog.xml                         |   4 +
 webapps/docs/rewrite.xml                           |   6 +-
 6 files changed, 234 insertions(+), 2 deletions(-)