Hello, we have a regression with version 9.0.31, it worked before with 9.0.30. Cause seems to be this commit: https://github.com/apache/tomcat/commit/fdcb3656239065654909ca55994787c027dbe583#diff-dc73b9f0609a4d3593f8a1f789ac1496 17-Feb-2020 09:45:56.925 SCHWERWIEGEND [catalina-exec-5] org.apache.coyote.http11.Http11Processor.service Fehler bei der Verarbeitung der Anfrage java.lang.NullPointerException at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:685) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343) at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:367) at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65) at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1639) at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) Kind regards, Roland
Please post the configuration.
Sorry, can't help you with that atm as I don't have access. I'll see what I can get. Aside from that, I suppose a null check won't hurt?
We need to find out why the NPE is occurring first. We don't want to mask a symptom of a bug elsewhere. Better to see the NPE so we know there is a problem. Hence the request for more info so we can figure out what is going on.
Created attachment 37118 [details] our server.xml I attached the server.xml. I think the problem here is one of the valves in the end. This used to work in 9.0.30. We also switched the handler to rotatable = false in the logging config, aside from that it is all defaults. The problem still persists in 9.0.33
Ok, I can reproduce and will fix this "issue".
There was a NPE when no pattern is specified. In that case, the valve does nothing so remove it. The fix will be in 10.0.0-M4, 9.0.34 and 8.5.54.
Aweseome :) Thank you very much