Bug 64238 - [PATCH] Make LOOKUP functions deal with empty last arg correctly
Summary: [PATCH] Make LOOKUP functions deal with empty last arg correctly
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: SS Common (show other bugs)
Version: unspecified
Hardware: All All
: P2 minor (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2020-03-18 14:24 UTC by Patrick Böker
Modified: 2020-10-25 07:24 UTC (History)
0 users


Attachments
lookup_missing_param.patch (1.25 KB, patch)
2020-03-18 14:24 UTC, Patrick Böker 		Details | Diff
LookupFunctionsTestCaseData.xls (68.50 KB, application/octet-stream)
2020-03-18 14:25 UTC, Patrick Böker 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Böker 2020-03-18 14:24:10 UTC 
Created attachment 37103 [details]
lookup_missing_param.patch

In `=VLOOKUP(A1,A2:C3,2,)` the last arg was seen as TRUE in POI, but FALSE in Excel 2003 and Excel 2013.

This patch makes POI behave like Excel in this regard.
I have added some tests to verify the bahvior.
Comment 1 Patrick Böker 2020-03-18 14:25:24 UTC 
Created attachment 37104 [details]
LookupFunctionsTestCaseData.xls

To be placed in test-data\spreadsheet\LookupFunctionsTestCaseData.xls
Comment 2 Dominik Stadler 2020-10-25 07:24:09 UTC 
Applied via r1882827, thanks for the patch and the updated test-case!