Bug 64247 - no-op JarScanner breaks back compatibility
Summary: no-op JarScanner breaks back compatibility
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 9
Classification: Unclassified
Component: Catalina (show other bugs)
Version: 9.0.31
Hardware: PC Mac OS X 10.1
: P2 normal (vote)
Target Milestone: -----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-20 04:06 UTC by quaff
Modified: 2020-03-23 01:49 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 quaff 2020-03-20 04:26:55 UTC
If it's a designed feature, It should be targeted at tomcat 10, add a warning in upgrade guide.
Comment 2 Remy Maucherat 2020-03-20 09:04:11 UTC
I tried:
jarsToSkip=*
jarsToScan=somelistofjars

I fail to see an issue, especially "As of 9.0.31, this now causes cascading startup failures.". Please accurately and fully describe the configuration and problems.

We sometimes change undocumented behaviors that we consider to be broken. It is rare but it happens. Sometimes a flag is added to optionally restore them. First I need to understand the issue.
Comment 3 Remy Maucherat 2020-03-20 13:54:40 UTC
I think I could figure it out in the code. You did mean that jarsToSkip=* overrides whatever is set as jarsToScan I suppose. That's likely not what's intended since jarsToScan is documented as having higher priority than jarsToSkip. The wildcard will no longer set the ignore everything flag if jarsToScan is present. Not sure if that configuration makes that much sense overall though.
The fix will be in 10.0.0-M4, 9.0.34, 8.5.54 and 7.0.104.
Comment 4 quaff 2020-03-23 01:49:12 UTC
(In reply to Remy Maucherat from comment #3)
> I think I could figure it out in the code. You did mean that jarsToSkip=*
> overrides whatever is set as jarsToScan I suppose. That's likely not what's
> intended since jarsToScan is documented as having higher priority than
> jarsToSkip. The wildcard will no longer set the ignore everything flag if
> jarsToScan is present. Not sure if that configuration makes that much sense
> overall though.
> The fix will be in 10.0.0-M4, 9.0.34, 8.5.54 and 7.0.104.

You are right.