Bug 64371 - suexec.c safe_env_lst is not sorted alphabetically
Summary: suexec.c safe_env_lst is not sorted alphabetically
Status: RESOLVED FIXED
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: support (show other bugs)
Version: 2.5-HEAD
Hardware: All All
: P2 minor (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: FixedInTrunk
Depends on:
Blocks:
 
Reported: 2020-04-21 21:43 UTC by Roland Illig
Modified: 2020-04-22 06:55 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Illig 2020-04-21 21:43:04 UTC
REQUEST_URI should come after REQUEST_SCHEME.

This is currently no problem since the save_env_lst is search linearly, but having this almost alphabetically sorted list looks as if a binary search might be implemented someday.

The order of the variable names should be fixed.
The order of the variable names should be checked statically so that any future updates ensure that the variable names are sorted correctly.

Same for SERVER_ADDR and SERVER_ADMIN.
Comment 1 Giovanni Bechis 2020-04-22 06:55:52 UTC
Fixed in r1876815, thanks.