Bug 64411 - Provide JigSaw modules
Summary: Provide JigSaw modules
Status: NEW
Alias: None
Product: POI
Classification: Unclassified
Component: POI Overall (show other bugs)
Version: 4.1.x-dev
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
Depends on:
Reported: 2020-05-05 13:24 UTC by Andreas Beeker
Modified: 2020-07-22 22:11 UTC (History)
0 users


Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Beeker 2020-05-05 13:24:09 UTC
This is a continuation of bug 62355. We should provide named modules to better support JigSaw modules.

The simple way would be to only add a manifest entry - but this is limiting the JigSaw feature. So I've decided to provide multi release modules.
Currently only the module-info class is provided, but that might change when other elements in the JDK get deprecated too.


Comment 1 Andreas Beeker 2020-05-05 13:47:10 UTC
the first patch (r1877398) contained ...
- remove dependency to jaxb:
this was only used for loading the preset shape definitions and custom geometry for slideshow. With the deprecation of jaxb in jdk 11, further dependencies would have been necessary ... providing a custom parser for the shape definitions was the light weighted solution

- add a dependency macro in build.xml

- changed the library layout
all the libraries are now in sub directories under /lib.
when using the module-path directive, java hiccups on the utility libraries (don't know which one it was), so separating the libraries after its usage in the poi modules is more clean

- add module info to xml schema jars (initial)
tbd: is the merged schema, which is released and the lite schema

- add module info to main module (initial)

- provided the schema sources in our svn tree
every now and then, we have connection problems to the ecma server and it simply doesn't make sense to download 35mb when only 200kb of schemas are necessary
Comment 2 Eugene Kortov 2020-05-27 19:50:25 UTC
After rearranging some lib folders of ooxml in https://github.com/apache/poi/commit/114a4dbd41c56e4c544836e58fae02aae6793cdf, gradle build (and therefore IDE imports) was broken. This pr https://github.com/apache/poi/pull/183 fixes the issue.
Comment 3 Andreas Beeker 2020-07-22 22:11:01 UTC
applied via r1880164
- use classpath-build for Java 8, otherwise use modulepath
- save module-info classes to source, when using Java 9+ environment
- rename example packages - otherwise package clashes occured in the tests
- move agile encryption from ooxml to main.
  remove EncryptionInfo XmlBeans and schema and use custom xml marshalling
- move ooxml test classes which reside in the same package as their tested main class
- rename base test classes to "BaseTest..." - temporarily I've used a light version of the main test classes to test scratchpad / ooxml
- build.xml - fixed the Rhino javascript errors of the dependency-macros
- DrawTextParagraph - fixed StringIndexOutOfBounds when logging set to debug level
- use JigSaw provider interface (= Java ServiceLoader), i.e. it wasn't possible (without setting everything to open), to access ooxml factory classes from main factory stub