Bug 64454 - Error message too vague
Summary: Error message too vague
Status: NEEDINFO
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 5.3
Hardware: PC All
: P2 enhancement (vote)
Target Milestone: JMETER_5.3.0
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-19 15:02 UTC by David Balažic
Modified: 2020-05-28 14:42 UTC (History)
1 user (show)



Attachments
Be more precise, which element is blank (3.56 KB, patch)
2020-05-19 15:24 UTC, Felix Schumacher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Balažic 2020-05-19 15:02:00 UTC
The error message (shown in the Results Tree) is too vague:
Variable Name must not be null in JDBC Request


It is not clear which variable is set to null.
Comment 1 Felix Schumacher 2020-05-19 15:24:24 UTC
Created attachment 37251 [details]
Be more precise, which element is blank
Comment 2 Felix Schumacher 2020-05-28 14:08:40 UTC
@David, are the new error messages more to your liking? Can you test next nightly?

commit fe4d4d6074f844ff28acaf42f36765104fcf8471
AuthorDate: Thu May 28 16:06:26 2020 +0200

    More precise error message, when no datasource value can be found in JDBC sampler
    
    Bugzilla Id: 64454
---
 .../org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java     | 4 ++--
 .../apache/jmeter/protocol/jdbc/processor/AbstractJDBCProcessor.java  | 4 ++--
 .../java/org/apache/jmeter/protocol/jdbc/sampler/JDBCSampler.java     | 4 ++--
 xdocs/changes.xml                                                     | 1 +
 4 files changed, 7 insertions(+), 6 deletions(-)
Comment 3 David Balažic 2020-05-28 14:19:33 UTC
(looking at the commit) they look fine

When will the nightly be available?
Comment 4 Felix Schumacher 2020-05-28 14:42:38 UTC
Nightlies will be built in the night ;) I am not sure, when they will be built exactly.

You could even try to build the stuff yourself, or look at https://builds.apache.org/job/JMeter-trunk/ where they will be built more often than the nightlies.

commit a3128d243cfac7883194f24d6de599598fc675cf
AuthorDate: Thu May 28 16:36:41 2020 +0200

    Fix tests to check for changed error messages
    
    Follow-up to fe4d4d6074f844ff28acaf42f36765104fcf8471
    Bugzilla Id: 64454
---
 bin/testfiles/JDBC_TESTS.csv | 2 +-
 bin/testfiles/JDBC_TESTS.jmx | 2 +-
 bin/testfiles/JDBC_TESTS.xml | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)