Bug 64536 - XSSF not updating worksheet dimensions
Summary: XSSF not updating worksheet dimensions
Alias: None
Product: POI
Classification: Unclassified
Component: XSSF (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
Depends on:
Blocks: 65562
  Show dependency tree
Reported: 2020-06-19 07:29 UTC by Sheet JS
Modified: 2022-03-20 21:43 UTC (History)
0 users


Note You need to log in before you can comment on or make changes to this bug.
Description Sheet JS 2020-06-19 07:29:58 UTC
Context: https://github.com/SheetJS/sheetjs/issues/2011

The reported issue involves:
- file parsed by the XSSF library
- a cell was programmatically added using createRow/createCell API calls
- updated file was written

The user provided a sample file, attached to the GitHub comment https://github.com/SheetJS/sheetjs/issues/2011#issuecomment-646472892

Inspecting the file, POI appears to have added cells E8/F8 but did not update the worksheet range to include the new cells.

Is this known / expected behavior?
Comment 1 Dominik Stadler 2022-03-20 20:51:27 UTC
Bug #65562 reports the same for SXSSF
Comment 2 PJ Fanning 2022-03-20 21:13:10 UTC
Dominik - I think the XSSF and SXSSF issues should be treated differently. XSSFSheet has this code.

protected void write(OutputStream out)
        // finally, if we had at least one cell we can populate the optional dimension-field
        if(minCell != Integer.MAX_VALUE) {
            String ref = new CellRangeAddress(getFirstRowNum(), getLastRowNum(), minCell, maxCell).formatAsString();
            if(worksheet.isSetDimension()) {
            } else {

While in SXSSF, the issue is that the order of the XML is messed up. Microsoft chose to put the dimension in the sheet XML before the row data - so the SXSSF code doesn't yet know the dimensions when it writes the dimension data. It might be possible to get SXSSF to work by taking advantage of temp files and creating the sheet XML based on row data that is in temp files (and we then know how many rows there are.

In XSSF, this is so much easier because the whole sheet is in memory.
Comment 3 PJ Fanning 2022-03-20 21:43:01 UTC
The code is the linked sheetJs issue is pretty out of date. I wrote a new test - r1899091 and it passes ok. I added a new getDimension() method to XSSFSheet to help test.