Bug 64755 - [has patch] Improve the log message for dav_fs_copymove_file
Summary: [has patch] Improve the log message for dav_fs_copymove_file
Status: NEW
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: mod_dav_fs (show other bugs)
Version: 2.5-HEAD
Hardware: PC Mac OS X 10.1
: P2 normal (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2020-09-20 03:28 UTC by Bingyu Shen
Modified: 2020-09-29 05:40 UTC (History)
0 users



Attachments
A patch to improve the error message for dav_fs_copymove_file (1.36 KB, text/plain)
2020-09-20 03:28 UTC, Bingyu Shen
Details
New patch, fixed the spacing issue (1.03 KB, patch)
2020-09-20 17:35 UTC, Bingyu Shen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bingyu Shen 2020-09-20 03:28:23 UTC
Created attachment 37457 [details]
A patch to improve the error message for dav_fs_copymove_file

The previous log message only says "Could not open file for reading/writing",
but the file paths are different in reading or writing. I added the file name into the log message, so that people can see the which file path may have read/write permission problems.


Please find the attached patch. Any thoughts are appreciated!

------
* modules/dav/fs/repo.c: Add filepath in the log messages of
dav_fs_copymove_file to differentiate src and dst filepath
location
Comment 1 Bingyu Shen 2020-09-20 03:29:00 UTC
Also reported on GitHub. 

https://github.com/apache/httpd/pull/143
Comment 2 Christophe JAILLET 2020-09-20 10:08:57 UTC
Hi,

a space is missing between "...file" and "for...".
No need to update the proposal, I guess that it can be fixed when merged.
Comment 3 Bingyu Shen 2020-09-20 17:35:03 UTC
Created attachment 37458 [details]
New patch, fixed the spacing issue
Comment 4 Bingyu Shen 2020-09-20 17:36:28 UTC
(In reply to Christophe JAILLET from comment #2)
> Hi,
> 
> a space is missing between "...file" and "for...".
> No need to update the proposal, I guess that it can be fixed when merged.

Thanks, fixed that in the new patch.

Regards,
Bingyu