Bug 65020 - HTTP Sampler/Files upload tab - add missing buttons
Summary: HTTP Sampler/Files upload tab - add missing buttons
Status: NEW
Alias: None
Product: JMeter
Classification: Unclassified
Component: HTTP (show other bugs)
Version: Nightly (Please specify date)
Hardware: PC All
: P2 enhancement (vote)
Target Milestone: JMETER 5.4.1
Assignee: JMeter issues mailing list
URL:
Keywords: FixedInTrunk
Depends on:
Blocks:
 
Reported: 2020-12-22 00:22 UTC by eR@SeR
Modified: 2021-04-10 18:13 UTC (History)
0 users



Attachments
Detail, Add from clipboard, Up, Down buttons are missing (8.17 KB, image/jpeg)
2020-12-22 00:22 UTC, eR@SeR
Details
Add "up/down/add from clipboard" buttons (10.73 KB, patch)
2021-01-01 14:47 UTC, Felix Schumacher
Details | Diff
images (28.56 KB, application/x-zip-compressed)
2021-01-03 01:48 UTC, eR@SeR
Details
Add missing buttons (21.54 KB, patch)
2021-03-06 16:52 UTC, Felix Schumacher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description eR@SeR 2020-12-22 00:22:15 UTC
Created attachment 37640 [details]
Detail, Add from clipboard, Up, Down buttons are missing

Hello,

Files upload tab in HTTP Sampler is missing Detail, Add from clipboard, Up and Down buttons that are available in Parameters tab. By adding those buttons, user will be able to edit File path, Parameter and MIME-type values with more ease, Duplicate already added file upload parameter and sort two or more files as per his needs respectively.

Jmeter 5.4.1 10acbc7
Microsoft Windows 10 Pro 64-bit
java version "1.8.0_251"
Comment 1 Felix Schumacher 2021-01-01 14:47:39 UTC
Created attachment 37677 [details]
Add "up/down/add from clipboard" buttons

Do you really need the detail button? Have you used it before? What should it look like?
Comment 2 eR@SeR 2021-01-03 01:48:25 UTC
Created attachment 37682 [details]
images

(In reply to Felix Schumacher from comment #1)
> Created attachment 37677 [details]
> Add "up/down/add from clipboard" buttons
> 
> Do you really need the detail button? Have you used it before? What should
> it look like?
Hi,

There is a Detail button in the Parameters tab, so I don't see the reason why we should not have it in the Files upload tab. If the file path is longer it can be easier seen/edited inside Details, then to switch to the next parameter (if any) etc. It can have the same design as the current one. See image 1. I'm not sure whether to add MIME type below the value text box and split the value text box size into two equal parts.

I was wondering...why parameter name and file path columns are switched in JMeter? In Postman parameter goes first, then the actual file. See image 2. Can we have the same order of columns as we have in Postman?

P.S. Happy New Year to the whole community :)

Jmeter 5.4.1 c990226
Microsoft Windows 10 Enterprise 64-bit
java version "14.0.1" 2020-04-14
Comment 3 Felix Schumacher 2021-03-06 16:52:39 UTC
Created attachment 37758 [details]
Add missing buttons

This patch adds the detail button as well as the up/down/add from clipboard ones. It needs the patch from Bugzilla 65152 to work.
Comment 4 Felix Schumacher 2021-03-10 20:05:51 UTC
@Nikola, could you test next nightly or build from trunk?

commit bfacaf43f4debe663d5937cb42e6efa9adca8317
AuthorDate: Fri Jan 1 15:45:24 2021 +0100

    HTTP Sampler/Files upload tab - add missing buttons
    
    Bugzilla Id: 65020
---
 .../apache/jmeter/config/gui/RowDetailDialog.java  |  96 ++++++---
 .../protocol/http/gui/HTTPFileArgsPanel.java       | 231 +++++++++++++++++++--
 xdocs/changes.xml                                  |   1 +
 3 files changed, 288 insertions(+), 40 deletions(-)
Comment 5 eR@SeR 2021-03-11 20:19:59 UTC
Hi Felix,

The detail dialog box design looks fine. Maybe the following can be improved:

1. When file path box is filled with a path like "uploadFiles\image.jpg" in blank Detail pop up, then Tab button is pressed or clicked to Parameter name or MIME type box, it can be expected that MIME type box gets filled with content-type "image/jpeg" like it is the case in File path column in Files upload tab - I'm referring to this feature https://bz.apache.org/bugzilla/show_bug.cgi?id=65027

----

Add from clipboard, Up and Down buttons works as expected. However:

2. Keyboard shortcuts are not supported. Ctrl + A, press and hold Shift + Click won't select many rows, press and hold Ctrl + Click doesn't work...etc. This is working fine in the Parameters tab.

----

Also, I noticed that checkboxes "URL Encode" and "Include Equals" as well as "Content-Type" type box is added in Detail pop up in Parameters tab. Nice improvement :)

Jmeter 5.5 bfacaf4
Microsoft Windows 10 Pro 64-bit
java version "15.0.1" 2020-10-20
Comment 6 Felix Schumacher 2021-04-10 18:13:02 UTC
commit 4b834be91b39a2b70569bb4b930b1eb4d3bcaedf
Author: Felix Schumacher <felix.schumacher@internetallee.de>
AuthorDate: Sat Apr 10 20:11:35 2021 +0200

    No need to round an integer
    
    Part of: HTTP Sampler/Files upload tab - add missing buttons
    
    Bugzilla Id: 65020
---
 .../src/main/java/org/apache/jmeter/config/gui/RowDetailDialog.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)