Bug 65064 - Enhancement request: InfluxDBListenerClient: Return response codes in all scenarios, not just errors
Summary: Enhancement request: InfluxDBListenerClient: Return response codes in all sce...
Status: NEEDINFO
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: unspecified
Hardware: PC All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-07 10:14 UTC by Niall Ward
Modified: 2021-03-06 09:41 UTC (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Niall Ward 2021-01-07 10:14:05 UTC
Hi

Currently the InfluxDBBackendListenerClient does not report the request response codes, except in the context of errors:

 private void addErrorMetric(String transaction, ErrorMetric err, long count) {
        if (count <= 0) {
            return;
        }
        StringBuilder tag = new StringBuilder(70);
        tag.append(TAG_APPLICATION).append(applicationName);
        tag.append(TAG_TRANSACTION).append(transaction);
        tag.append(TAG_RESPONSE_CODE).append(AbstractInfluxdbMetricsSender.tagToStringValue(err.getResponseCode()));
        tag.append(TAG_RESPONSE_MESSAGE).append(AbstractInfluxdbMetricsSender.tagToStringValue(err.getResponseMessage()));
        tag.append(userTag);

        StringBuilder field = new StringBuilder(30);
        field.append(METRIC_COUNT).append(count);
        influxdbMetricsManager.addMetric(measurement, tag.toString(), field.toString());
    }

Could this behaviour be changed so that the response codes are reported in all instances?
Comment 1 Felix Schumacher 2021-03-06 09:41:34 UTC
I think that is possible, but I don't use that listener myself, so it would probably good to discuss this change on the dev or users mailing list first.