Bug 65152 - OS Process Sampler - Cannot "Add from Clipboard" Command parameters
Summary: OS Process Sampler - Cannot "Add from Clipboard" Command parameters
Status: NEEDINFO
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: Nightly (Please specify date)
Hardware: All All
: P2 normal (vote)
Target Milestone: JMETER_5.5
Assignee: JMeter issues mailing list
URL:
Keywords: FixedInTrunk, PatchAvailable
Depends on:
Blocks:
 
Reported: 2021-02-21 17:57 UTC by Felix Schumacher
Modified: 2021-03-11 20:53 UTC (History)
0 users



Attachments
Use clipboard for parameters more properly (2.48 KB, patch)
2021-02-21 17:57 UTC, Felix Schumacher
Details | Diff
Use clipboard for parameters more properly (7.05 KB, patch)
2021-02-23 16:25 UTC, Felix Schumacher
Details | Diff
Use clipboard for parameters more properly (11.27 KB, patch)
2021-02-27 15:30 UTC, Felix Schumacher
Details | Diff
Use clipboard for parameters more properly (13.47 KB, patch)
2021-03-06 12:14 UTC, Felix Schumacher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Schumacher 2021-02-21 17:57:53 UTC
Created attachment 37740 [details]
Use clipboard for parameters more properly

At https://lists.apache.org/thread.html/rf7adbddeea0c09cfece73c3c01ce81a56337e31b8c87577ae274438d%40%3Cuser.jmeter.apache.org%3E Shay Ginsbourg wrote:

Hi,

Tested on Windows 10 host with java version "11.0.9" 2020-10-20 LTS 64-bits:

Inside the "Command parameters" of the "OS Process Sampler", the keyboard
shortcut CTRL+V is correctly pasting strings, however, the "Add from
Clipboard" button is NOT pasting the same strings.

The "Environment Variables" area is working OK.

Please look into that.

---

The attached patch should fix that issue.
Comment 1 Felix Schumacher 2021-02-23 16:25:30 UTC
Created attachment 37743 [details]
Use clipboard for parameters more properly

This updated patch keeps the class used to display the Arguments the same, when saved as a test plan.
Comment 2 Felix Schumacher 2021-02-27 15:30:15 UTC
Created attachment 37748 [details]
Use clipboard for parameters more properly

Add special handling in RowDetailDialog to support editing the values

It probably would be better to ask the TableModel for the names and types of the elements in the model to display the correct fields instead of deciding on the count of the rows.
Comment 3 Felix Schumacher 2021-03-06 12:14:09 UTC
Created attachment 37757 [details]
Use clipboard for parameters more properly

Generalize RowDetailDialog.
Comment 4 Felix Schumacher 2021-03-10 20:04:52 UTC
@Shay, could you test next nightly or build from trunk?

commit 6010d208454930385547d8b0d8fb4a70ec4f5f98
AuthorDate: Sun Feb 21 18:56:33 2021 +0100

    OS Process Sampler - Cannot "Add from Clipboard" Command parameters
    
    Bugzilla Id: 65152
---
 .../apache/jmeter/config/gui/ArgumentsPanel.java   | 42 ++++++++++--
 .../apache/jmeter/config/gui/RowDetailDialog.java  | 77 +++++++++++-----------
 .../protocol/system/gui/SystemSamplerGui.java      | 16 ++---
 xdocs/changes.xml                                  |  1 +
 4 files changed, 86 insertions(+), 50 deletions(-)