Bug 65329 - Incorrect handling for WINVER in NMAKEmakefile
Summary: Incorrect handling for WINVER in NMAKEmakefile
Alias: None
Product: Tomcat Native
Classification: Unclassified
Component: Library (show other bugs)
Version: 1.2.28
Hardware: PC All
: P2 major (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
Depends on:
Reported: 2021-05-25 16:36 UTC by Michael Osipov
Modified: 2021-06-01 08:52 UTC (History)
1 user (show)


Note You need to log in before you can comment on or make changes to this bug.
Description Michael Osipov 2021-05-25 16:36:38 UTC
The supplied NMAKEmakefiles

* does not recognize Windows releases after 7 (8, 8.1, 10),
* passes incorrect macro values to activate features in the compiler, e.g,  -D_WIN32_WINNT=0x0700 for Windows 7. The value is wrong.

Proper values are documented here:
* https://docs.microsoft.com/en-us/cpp/porting/modifying-winver-and-win32-winnt?view=msvc-160
* https://docs.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-osversioninfoa

So those files need to add new values and fix existing incorrect values.
Comment 1 Michael Osipov 2021-05-25 19:35:47 UTC
Yet another resource: https://docs.microsoft.com/en-us/windows/win32/winprog/using-the-windows-headers
Comment 2 Mark Thomas 2021-06-01 08:52:13 UTC
Fixed for 1.2.30 onwards.