Bug 65353 - Make the used estimator for the percentile on dashboard configurable
Summary: Make the used estimator for the percentile on dashboard configurable
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: Nightly (Please specify date)
Hardware: All All
: P2 normal (vote)
Target Milestone: JMETER_5.5
Assignee: JMeter issues mailing list
URL:
Keywords: FixedInTrunk
Depends on:
Blocks:
 
Reported: 2021-06-03 17:33 UTC by Felix Schumacher
Modified: 2021-06-04 05:59 UTC (History)
0 users



Attachments
Make percentile estimator configurable (8.66 KB, patch)
2021-06-03 17:33 UTC, Felix Schumacher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Schumacher 2021-06-03 17:33:09 UTC
Created attachment 37889 [details]
Make percentile estimator configurable

We had quite a lot reports about the difference of the calculated percentiles between the Average Report and the HTML Report (Dashboard).

We might get rid of those differences, if we use the R_3 estimator from commons-math (https://commons.apache.org/proper/commons-math/javadocs/api-3.5/org/apache/commons/math3/stat/descriptive/rank/Percentile.EstimationType.html)

As some people will probably want to stay on the current (LEGACY estimator) implementation, let us keep that and use a new property (yay) to select the estimator.
Comment 1 Felix Schumacher 2021-06-03 17:40:37 UTC
commit 1647a2b0cb69c2bae415d22816df0065403f44a6
Author: Felix Schumacher <felix.schumacher@internetallee.de>
AuthorDate: Thu Jun 3 19:32:17 2021 +0200

    Make the estimator used for calculating percentiles on the dashboard configurable
    
    Bugzilla Id: 65353
---
 .../jmeter/visualizers/backend/SamplerMetric.java  |  9 +++--
 .../jmeter/visualizers/backend/UserMetric.java     |  5 ++-
 .../processor/DescriptiveStatisticsFactory.java    | 43 ++++++++++++++++++++++
 .../report/processor/PercentileAggregator.java     |  4 +-
 xdocs/changes.xml                                  |  1 +
 xdocs/usermanual/properties_reference.xml          |  6 ++-
 6 files changed, 60 insertions(+), 8 deletions(-)
Comment 2 Felix Schumacher 2021-06-04 05:59:44 UTC
Forgotten to use the window size in the new tool class.

commit f9083cc1533496444b28c24557d98d3ea9f9d409
AuthorDate: Fri Jun 4 07:55:30 2021 +0200

    Use windowsize while creating DescriptiveStatistics
    
    Part of Bugzilla Id: 65353
---
 .../apache/jmeter/report/processor/DescriptiveStatisticsFactory.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)