Bug 65612 - XSLF CustomGeometry - replace XmlStreamReader access with XmlBeans delegate
Summary: XSLF CustomGeometry - replace XmlStreamReader access with XmlBeans delegate
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: XSLF (show other bugs)
Version: 5.0.x-dev
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-03 20:54 UTC by Andreas Beeker
Modified: 2021-10-03 21:06 UTC (History)
0 users


Attachments
example file causing forever rendering with XmlStreamReader (305.98 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2021-10-03 20:54 UTC, Andreas Beeker 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Beeker 2021-10-03 20:54:22 UTC 
Created attachment 38054 [details]
example file causing forever rendering with XmlStreamReader

My pptx corpus has some files which took forever to be rendered. The culprit was the double (or more) parsing of custom geometry parts via the XmlStreamReader interface.

The XmlStreamReader is still used to parsed the preset shapes in the Common SL package (in the main module) which doesn't allow to use XmlBeans. But in XSLF, it's not necessary to parse the slides XmlBeans over and over again.

Attached is a sample slide which causes that expensive execution flow.
Comment 1 Andreas Beeker 2021-10-03 21:06:04 UTC 
Applied via r1893859