Bug 65951 - ant package with custom tomcat.output fails in add-osgi
Summary: ant package with custom tomcat.output fails in add-osgi
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 9
Classification: Unclassified
Component: Packaging (show other bugs)
Version: 9.0.59
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: -----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-13 20:19 UTC by Igal Sapir
Modified: 2022-05-26 16:56 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Igal Sapir 2022-03-13 20:19:03 UTC 
The paths to the manifest files ignore the tomcat.output property, instead hard coding a relative path with ../..

Patch coming up.
Comment 1 Igal Sapir 2022-03-13 21:50:14 UTC 
Fixed for main  https://github.com/apache/tomcat/commit/39761d987d0edf1473a87472012a946de79d1017
Fixed for 9.0.x https://github.com/apache/tomcat/commit/8b93b46c9eb8c3bd931da6f8edffe66f71828edd

Other active branches seem not to be affected by this issue.
Comment 2 Konstantin Kolinko 2022-03-14 16:38:02 UTC 
You skipped 10.0.x. It needs a fix as well.
Comment 3 Igal Sapir 2022-03-14 17:20:44 UTC 
(In reply to Konstantin Kolinko from comment #2)
> You skipped 10.0.x. It needs a fix as well.

You are right.  I wonder why I didn't get the same error that I did in the other branches.

I will patch that ASAP.
Comment 4 Konstantin Kolinko 2022-03-15 08:31:09 UTC 
I see that this was fixed in 10.0.x by
https://github.com/apache/tomcat/commit/e38672aa1a0beaf7ffa285b120fb048f4609ca75

Thank you.
Comment 5 Matt M 2022-05-26 16:23:10 UTC 
The fix for 9.0.x is missing a fix to this file:

res/bnd/tomcat-embed-el.jar.tmp.bnd

The fix for 10.0.x has it.
Comment 6 Mark Thomas 2022-05-26 16:56:34 UTC 
Fixed in:
- 9.0.x for 9.0.64 onwards