Bug 66061 - DefaultSamplerCreator gives inaccurate log message saying "setting path ... " after already set the path
Summary: DefaultSamplerCreator gives inaccurate log message saying "setting path ... ...
Status: NEW
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: HTTP (show other bugs)
Version: unspecified
Hardware: All All
: P2 trivial (vote)
Target Milestone: JMETER_5.5
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-11 15:50 UTC by Ding Ding
Modified: 2022-05-11 15:50 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ding Ding 2022-05-11 15:50:57 UTC 
Hello,

While viewing the https://issues.apache.org/jira/browse/MAPREDUCE-4262, I found that the logging statements might give inaccurate messages. 

I also found that the in the line 420 of the file DefaultSamplerCreator.java, the log messages says "setting path...". However, the path should already be set in previous lines of code.

Would it be better if we change the verb "setting" to "have set" to indicate the action is completed? Or can we move the logging statement to the begining of the method? Since when there was an exception in previous lines, the logging message would not be printed, which may be not good for debugging.


The detailed url is:
https://github.com/apache/jmeter/blob/659c1ff5eaea941eb7ad0638b58e904dcc06d961/src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java/#L420
Comment 1 The ASF infrastructure team 2022-09-24 20:38:23 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/5668