Bug 66138 - Log level ERROR is too severe in ZipPackage when we will try a fall back
Summary: Log level ERROR is too severe in ZipPackage when we will try a fall back
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: OPC (show other bugs)
Version: 5.2.2-FINAL
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-22 12:55 UTC by Matafagafo
Modified: 2022-06-22 13:25 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matafagafo 2022-06-22 12:55:40 UTC
In ZipPackage line 174 (in trunk)  when one IOException is thrown by ZipFileZipEntrySource the code tries to fall back to stream processing, and a log message severity ERROR is generated.

The mentioned line code:

LOG.atError().log("Error in zip file {} - falling back to stream processing (i.e. ignoring zip central directory)", file);



In my opinion, the ERROR severity is too high, as the code will try a fall back.
As ERROR severity logs, in our environment, generate some actions to evaluate what is happening, this can be unnecessary, because the fall back may successfully circumvent the problem.

So my suggestion is to decrease to WARNING severity.
Comment 1 PJ Fanning 2022-06-22 13:25:56 UTC
Changed with r1902170