Bug 66359 - Document default value for RemoteIpValve#protocolHeader and RemoteIpFilter#protocolHeader
Summary: Document default value for RemoteIpValve#protocolHeader and RemoteIpFilter#pr...
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 9
Classification: Unclassified
Component: Catalina (show other bugs)
Version: 9.0.19
Hardware: All All
: P2 trivial (vote)
Target Milestone: -----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on: 63196
Blocks:
  Show dependency tree
 
Reported: 2022-11-21 23:00 UTC by Eric Hamilton
Modified: 2022-12-05 20:11 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Hamilton 2022-11-21 23:00:40 UTC 
Update the Java documentation for RemoteIpValve and RemoteIpFilter with the correct protocolHeader default value of "x-forwarded-proto".  Documentation still shows default value as "null", although this value was changed with Bug 63196.  JavaDoc updates are needed in both the class and setProtocolHeader method locations.
Comment 1 Han Li 2022-11-22 03:18:45 UTC 
Fixed in:
- 11.0.x for 11.0.0-M1 onwards
- 10.1.x for 10.1.3 onwards
- 9.0.x for 9.0.70 onwards
- 8.5.x for 8.5.85 onwards