Bug 66621 - Bug in WebdavServlet?
Summary: Bug in WebdavServlet?
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 8
Classification: Unclassified
Component: Catalina (show other bugs)
Version: 8.5.89
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-31 13:12 UTC by Alexander Veit
Modified: 2023-05-31 16:59 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Veit 2023-05-31 13:12:41 UTC 
While looking at the WebdavServlet source code I spotted the following line where expired collection locks are being removed from the resource locks:

https://github.com/apache/tomcat/blob/8.5.x/java/org/apache/catalina/servlets/WebdavServlet.java#L1064

However, the usual pattern seems to be that expired locks are being removed from the same collection they were found in. So this may be a bug. Is this correct?
Comment 1 Mark Thomas 2023-05-31 16:59:10 UTC 
Thanks for spotting that. I agree that there is a bug there.


Fixed in:
- 11.0.x for 11.0.0-M7 onwards
- 10.1.x for 10.1.10 onwards
-  9.0.x for  9.0.76 onwards
-  8.5.x for  8.5.90 onwards