Bug 9562 - [FEATURE REQUEST] HSSFCell.getCellValueRecord() should be public
Summary: [FEATURE REQUEST] HSSFCell.getCellValueRecord() should be public
Status: RESOLVED WONTFIX
Alias: None
Product: POI
Classification: Unclassified
Component: HSSF (show other bugs)
Version: 2.0-dev
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-06-01 15:28 UTC by Werner Froidevaux
Modified: 2004-11-16 19:05 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Werner Froidevaux 2002-06-01 15:28:44 UTC 
The method  

protected CellValueRecordInterface getCellValueRecord()
    {
        return record;
    }

in HSSFCell is declared 'protected'. To implement a formula calculator I need 
access to the record from other packages. Couldn't the method be declared 
as 'public'. HSSFCell.getCellFormula() is too ineficient.
Comment 1 Andy Oliver 2002-06-01 15:45:34 UTC 
No it shouldn't be public.  I would say the formula evalutor should work exactly
the opposite way.  It should be independant of the underlying model.

Making that public would break our encapsulation and clear seperation between
the low level model and high level.
Comment 2 Andy Oliver 2002-06-01 19:25:18 UTC 
Now you're talking.
Comment 3 Andy Oliver 2002-06-10 03:29:26 UTC 
should not be made public