diff -r 23c3cf40cca4 keyring/src/org/netbeans/modules/keyring/kde/KWalletProvider.java --- a/keyring/src/org/netbeans/modules/keyring/kde/KWalletProvider.java Fri Apr 23 13:38:21 2010 +0200 +++ b/keyring/src/org/netbeans/modules/keyring/kde/KWalletProvider.java Fri Apr 23 16:13:46 2010 +0200 @@ -75,7 +75,6 @@ @Override public char[] read(String key){ - runCommand("close", runCommand("localWallet"), "true".toCharArray() ); if (updateHandler()){ char[] pwd = runCommand("readPassword", handler, getApplicationName(), key.toCharArray(), getApplicationName(true)); runCommand("close", runCommand("localWallet"), "true".toCharArray() ); @@ -88,7 +87,6 @@ public void save(String key, char[] password, String description){ //description is forgoten ! kdewallet dosen't have any facility to store //it by default and I don't want to do it by adding new fields to kwallet - runCommand("close", runCommand("localWallet"), "true".toCharArray() ); if (updateHandler()){ if (new String(runCommand("writePassword", handler , getApplicationName() , key.toCharArray(), password , getApplicationName(true)) @@ -103,7 +101,6 @@ @Override public void delete(String key){ - runCommand("close", runCommand("localWallet"), "true".toCharArray() ); if (updateHandler()){ if (new String(runCommand("removeEntry" ,handler, getApplicationName() , key.toCharArray() , getApplicationName(true) @@ -144,7 +141,9 @@ Runtime rt = Runtime.getRuntime(); String retVal = ""; try { - + if (logger.isLoggable(Level.FINE)) { + logger.log(Level.FINE, "executing {0}", Arrays.toString(argv)); + } Process pr = rt.exec(argv); BufferedReader input = new BufferedReader(new InputStreamReader(pr.getInputStream())); @@ -169,10 +168,9 @@ int exitVal = pr.waitFor(); - if(exitVal!=0){ - logger.log(Level.FINE,"application exit with code "+exitVal+" for commandString: "+Arrays.toString(argv)); + if (logger.isLoggable(Level.FINE)) { + logger.log(Level.FINE, "application exit with code {0} for commandString: {1}", new Object[]{exitVal, Arrays.toString(argv)}); } - } catch (InterruptedException ex) { logger.log(Level.FINE, "exception thrown while invoking the command \""+Arrays.toString(argv)+"\"",