Bug 121215

Created attachment 52550 [details]
Overlapping Labels

It could be done seamlessly by introducing a new Layout. The only issue is how to resolve the new location of
overlapping widgets. If the Layout should be built-in the library, then it should have this location resolving customizable.

I created a new example in the examples project that demonstrates this issue.  That way when the issue is fixed, we also have an example built.  The name of 
the example is test.connectionlabels.LabelsWithSameAnchorTest.

Created attachment 65667 [details]
Replacement for ConnectionWidgetLayout class

Created attachment 65668 [details]
Updated version of the test which uses the new version of ConnectionWidgetLayout

I have attached two files:
1) StackedConnectionWidgetLayout class is a new/rewritten version of ConnectionWidgetLayout class from the visual
library source code.
2) LabelsWithSameAnchorTest class is updated version of the original test class that uses the new
StackedConnectionWidgetLayout class.

This new StackedConnectionWidgetLayout is having a single boolean parameter. If it is false, then it behaves as original
implementation. If it is true, then the overlapping child-widgets are stacks vertically.

To integrate this into the library, I would recommend to:
1) replace original ConnectionWidgetLayout class implementation with the new one
2) LayoutFactory should have a new factory method with boolean parameter...
3) ConnectionWidget should have a new connectionWidgetLayoutPolicy property that would modify the "useStacking" field in
the new implementation since by default it has to behave as it behaving right now because of backward-compatibility.

Patch available.

Patch integrated in 6dd4773a30a9. I think it is not necessary to keep defective behavior for backward compatibility, but
in case someone needs it please reopen this issue and I will add support for old behavior as David suggested.

Integrated into 'main-golden', available in build *200808280201* on http://bits.netbeans.org/dev/nightly/
Changeset: http://hg.netbeans.org/main/rev/6dd4773a30a9
User: Tomas Holy <t_h@netbeans.org>
Log: #121215: Labels Overlap

This does not seem to have fixed our problem.  From looking at the diff it looks like the stacking should be on by default.   However as you can see from the 
image I am attaching it does not seem to be working.  As you can tell from the image there is enough space between the connection widget and the label for 
two labels, however they are stacked on top of each other. 

Also from Davids comments about how it is to be implemented I do not see a way to change the useStacking property.

Created attachment 69557 [details]
Example of new stacking behavior

Yes, there is only version with stacking support, no need to set any property. Can you please provide example where
stacking fails?

Well one example is the UML I showed in the attached image.  If you want me to write a small example I will try to get that for you.

I was able to reproduce the problem with one of the existing examples.

http://hg.netbeans.org/main/contrib/file/ee63cdc1f9df/visual.examples/src/test/connectionlabels/LabelsWithSameAnchorTest.java

Created attachment 70084 [details]
The test works for me, no overlapping labels

closing as works for me, please reopen with information how to reproduce

The difference is that the example test case uses the connection widget layout alignment of CENTER_TOP.  However if you use a alignment of TOP_CENTER 
you will see the behavior that I described.  I am attaching a source file that demonstrates the behavior.

Created attachment 70361 [details]
Demonstrates the overlapping label problem.

de5680ad6416

Integrated into 'main-golden', will be available in build *200809250201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/de5680ad6416
User: Tomas Holy <t_h@netbeans.org>
Log: #121215: Labels Overlap

I have verified that is now working for my usecase.