This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Added new NameKind in ClassIndex for code completion | ||
|---|---|---|---|
| Product: | java | Reporter: | Tomas Zezula <tzezula> |
| Component: | Source | Assignee: | Tomas Zezula <tzezula> |
| Status: | VERIFIED FIXED | ||
| Severity: | blocker | CC: | jtulach |
| Priority: | P2 | Keywords: | API, API_REVIEW_FAST |
| Version: | 6.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Attachments: | Diff | ||
|
Description
Tomas Zezula
2007-11-27 15:57:14 UTC
Created attachment 53556 [details]
Diff
Proposed patch looks OK. Seems fine to me. Checking in src/org/netbeans/api/java/source/ClassIndex.java; /cvs/java/source/src/org/netbeans/api/java/source/ClassIndex.java,v <-- ClassIndex.java new revision: 1.13; previous revision: 1.12 done Checking in src/org/netbeans/modules/java/source/usages/LuceneIndex.java; /cvs/java/source/src/org/netbeans/modules/java/source/usages/LuceneIndex.java,v <-- LuceneIndex.java new revision: 1.29; previous revision: 1.28 done Y01 No test, no @since tag, no apichanges. Btw. why you integrated so early after announcing the review? Is there a reason to be in hurry? Y01: Added since and apichanges. No test - well I believe there are lots of tests testing adding of enum entry into enums (about the API test). The test of implementation - currently implemented as merge of CAMEL_CASE and CIPrefix both already covered and it will be rewritten to improve the performance. API review very fast - it's needed to fix another issue. Anyway the only persons who know the ClassIndex already reviewed it, there is no need to wait. Checking in apichanges.xml; /cvs/java/source/apichanges.xml,v <-- apichanges.xml new revision: 1.19; previous revision: 1.18 done Checking in nbproject/project.properties; /cvs/java/source/nbproject/project.properties,v <-- project.properties new revision: 1.41; previous revision: 1.40 done Checking in src/org/netbeans/api/java/source/ClassIndex.java; /cvs/java/source/src/org/netbeans/api/java/source/ClassIndex.java,v <-- ClassIndex.java new revision: 1.14; previous revision: 1.13 done . |