This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | missing save before commit | ||
---|---|---|---|
Product: | versioncontrol | Reporter: | Tomas Stupka <tstupka> |
Component: | Mercurial | Assignee: | issues@versioncontrol <issues> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | ||
Priority: | P3 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | proposed patch |
Description
Tomas Stupka
2008-02-01 13:25:54 UTC
I have compared the behavior of subversion with mercurial and subversion seems to save changed file before commit dialog is displayed. Can you tell me how this is done? ContextAction.performAction() { ... LifecycleManager.getDefault().saveAll(); ... } Created attachment 55921 [details]
proposed patch
I have added ui/actions/ContextAction.java and made our menu actions extend ContextAction instead of AbstractAction. I also moved the call to if(!Mercurial.getInstance().isGoodVersionAndNotify()) return; to ContextAction.actionPerfomed. changeset: 65546:6fe1f6d70356 user: padraigob@netbeans.org date: Fri Feb 01 16:09:20 2008 +0000 files: mercurial/src/org/netbeans/modules/mercurial/ui/actions/ContextAction.java mercurial/src/org/netbeans/modules/mercurial/ui/add/AddAction.java mercurial/src/org/netbeans/modules/mercurial/ui/annotate/AnnotateAction.java mercurial/src/org/netbeans/modules/mercurial/ui/clone/CloneAction.java mercurial/src/org/netbeans/modules/mercurial/ui/clone/CloneExternalAction.java mercurial/src/org/netbeans/modules/mercurial/ui/commit/CommitAction.java mercurial/src/org/netbeans/modules/mercurial/ui/commit/ExcludeFromCommitAction.java mercurial/src/org/netbeans/modules/mercurial/ui/create/CreateAction.java mercurial/src/org/netbeans/modules/mercurial/ui/diff/DiffAction.java mercurial/src/org/netbeans/modules/mercurial/ui/diff/ExportDiffAction.java mercurial/src/org/netbeans/modules/mercurial/ui/diff/ImportDiffAction.java mercurial/src/org/netbeans/modules/mercurial/ui/ignore/IgnoreAction.java mercurial/src/org/netbeans/modules/mercurial/ui/log/LogAction.java mercurial/src/org/netbeans/modules/mercurial/ui/log/OutAction.java mercurial/src/org/netbeans/modules/mercurial/ui/log/SearchHistoryAction.java mercurial/src/org/netbeans/modules/mercurial/ui/merge/MergeAction.java mercurial/src/org/netbeans/modules/mercurial/ui/properties/PropertiesAction.java mercurial/src/org/netbeans/modules/mercurial/ui/pull/FetchAction.java mercurial/src/org/netbeans/modules/mercurial/ui/pull/PullAction.java mercurial/src/org/netbeans/modules/mercurial/ui/pull/PullOtherAction.java mercurial/src/org/netbeans/modules/mercurial/ui/push/PushAction.java mercurial/src/org/netbeans/modules/mercurial/ui/push/PushOtherAction.java mercurial/src/org/netbeans/modules/mercurial/ui/remove/RemoveAction.java mercurial/src/org/netbeans/modules/mercurial/ui/rollback/RollbackAction.java mercurial/src/org/netbeans/modules/mercurial/ui/serve/ServeAction.java mercurial/src/org/netbeans/modules/mercurial/ui/status/StatusAction.java mercurial/src/org/netbeans/modules/mercurial/ui/update/ConflictResolvedAction.java mercurial/src/org/netbeans/modules/mercurial/ui/update/ResolveConflictsAction.java mercurial/src/org/netbeans/modules/mercurial/ui/update/RevertModificationsAction.java mercurial/src/org/netbeans/modules/mercurial/ui/update/UpdateAction.java mercurial/src/org/netbeans/modules/mercurial/ui/view/ViewAction.java description: 126495: save changed files before executing menu item changeset: 65835:47bec22ca462 tag: tip parent: 65546:6fe1f6d70356 parent: 65834:1bf83fdabaad user: padraigob@netbeans.org date: Tue Feb 05 08:49:49 2008 +0000 files: gsf/src/org/netbeans/modules/gsfret/source/usages/NBLockFactory.java ruby.railsprojects/src/org/netbeans/modules/ruby/railsprojects/server/Mongrel.java ruby.railsprojects/src/org/netbeans/modules/ruby/railsprojects/server/RailsAppChildrenFactory.java ruby.railsprojects/src/org/netbeans/modules/ruby/railsprojects/server/RailsServerManager.java ruby.railsprojects/src/org/netbeans/modules/ruby/railsprojects/server/RubyServer.java ruby.railsprojects/src/org/netbeans/modules/ruby/railsprojects/server/ServerRegistry.java ruby.railsprojects/src/org/netbeans/modules/ruby/railsprojects/server/WEBrick.java ruby.railsprojects/src/org/netbeans/modules/ruby/railsprojects/server/nodes/RubyServerNode.java ruby.railsprojects/test/unit/src/org/netbeans/modules/ruby/railsprojects/server/RubyServerTest.java spring.beans/src/org/netbeans/modules/spring/beans/completion/Bundle.properties spring.beans/src/org/netbeans/modules/spring/beans/completion/CompletionManager.java spring.beans/src/org/netbeans/modules/spring/beans/completion/SpringXMLConfigCompletionDoc.java spring.beans/src/org/netbeans/modules/spring/beans/completion/SpringXMLConfigCompletionItem.java spring.beans/src/org/netbeans/modules/spring/beans/completion/SpringXMLConfigCompletionProvider.java versioning.util/src/org/netbeans/modules/versioning/util/CommandReport.form versioning.util/src/org/netbeans/modules/versioning/util/CommandReport.java websvc.saas.api/build/classes/org/netbeans/modules/websvc/saas/util/Bundle.properties websvc.saas.api/src/org/netbeans/modules/websvc/saas/model/package-info.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/Bundle.properties xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeAttlistDeclAttributeDefBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeAttlistDeclBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeAttributeBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeCDATASectionBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeCharacterReferenceBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeCommentBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeConditionalSectionBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeDTDBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeDocumentBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeDocumentFragmentBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeDocumentTypeBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeElementBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeElementDeclBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeEntityDeclBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeGeneralEntityReferenceBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeNodeFilterBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeNotationDeclBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeParameterEntityReferenceBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeProcessingInstructionBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeTextBeanInfo.java xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/Util.java description: Automated merge with http://hg.netbeans.org/main pushing to https://padraigob:WCOZzCfY@hg.netbeans.org/main searching for changes adding changesets adding manifests adding file changes added 3 changesets with 48 changes to 46 files |