This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Excessive logging of exceptions for unknown files | ||
---|---|---|---|
Product: | versioncontrol | Reporter: | _ tboudreau <tboudreau> |
Component: | Mercurial | Assignee: | issues@versioncontrol <issues> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | Keywords: | PERFORMANCE |
Priority: | P3 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | proposed patch |
Description
_ tboudreau
2008-03-13 00:49:39 UTC
We are doing essestially the same as the Subversion module here. Transferring to versioning for further evaluation. You have to evaluate the error state in MercurialVCS.getOriginalFile() and only log exceptions that really signal some exceptional situation. The fact that you won't get a BASE version of a NEW file is certainly not exceptional and you should not log any error in such case. DiffSidebar does not know about status of your files. I think that check for STATUS_DIFFABLE fails in Hg for some reason. That the check for STATUS_DIFFABLE fails would explain why we would get an exception. However, I have not been able to reproduce this problem this morning. When I create a new file its status in getOriginalFile is LocallyNew and the exception does not occur. Do you have a reproducible test case for this? I have just seen the problem happen. Created attachment 58577 [details]
proposed patch
Patch committed in changeset 73978:cb2d91802f02. *** Issue 128402 has been marked as a duplicate of this issue. *** |