This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 172606

Summary:	Color profiles: No effect on the background color of Diff sidebar
Product:	editor	Reporter:	ziakjan <ziakjan>
Component:	Options	Assignee:	Milutin Kristofic <mkristofic>
Status:	REOPENED ---
Severity:	blocker	CC:	midnightlightning, msauer, ovrabec, tstupka
Priority:	P4
Version:	7.3.1
Hardware:	PC
OS:	Linux
Issue Type:	DEFECT	Exception Reporter:

Description ziakjan 2009-09-19 18:47:53 UTC

Contents of the diff sidebar are unreadable when selecting color profile with a dark background color.

Applies to: NetBeans IDE Dev (Build 200909151512) and previous versions

Related issues: http://www.netbeans.org/issues/show_bug.cgi?id=146124

Steps to reproduce:
1. Go to "Tools" > "Options" > "Fonts & Colors"
2. Select profile "Norway today"
3. Click OK
4. Open a file which utilizes versioning
5. Make changes to the file
6. Click on a bar in the diff sidebar to view the original file contents. This shows a popup window.
7. In the popup window: Text which is rendered with white (or similar) color is unreadable.

The problem is that the sidebar background color is *not* a part of a color profile. Instead it can/needs to be
configured separately through "Tools" > "Options" > "Fonts & Colors" > "Diff" > "Background color of ... in Sidebar".

Suggested solution: Integrate the diff sidebar's background color into the color profiles and define appropriate default
colors

Comment 1 Max Sauer 2009-09-21 13:37:16 UTC

Reassigning, please evaluate.

Comment 2 Tomas Stupka 2009-09-23 14:28:42 UTC

agree, it makes sense to setup the diffsidebar colors in the color profile. reassigning back to editor.



as already mentioned the background colors for the diffsidebar popups can be changed in "Tools" > "Options" > "Fonts &
Colors" > "Diff" > "Background color of ... in Sidebar". Regarding http://wiki.netbeans.org/BugPriorityGuidelines this
is not a p3 defect, more like a minor usability problem -> p4.

Comment 3 ahildoer 2012-02-23 16:58:31 UTC

+1 

Problem exists on Netbeans 7.1 on Mac OS X Lion as of 2012/02/23

Comment 4 Martin Balin 2016-07-07 07:30:38 UTC

This old bug may not be relevant anymore. If you can still reproduce it in 8.2 development builds please reopen this issue.

Thanks for your cooperation,
NetBeans IDE 8.2 Release Boss

Comment 5 midnightlightning 2016-07-15 19:22:38 UTC

This is still an issue. It is possible to manually go to the Options > Fonts & Colors > Diff panel and manually set the "Background Color of Deleted/Changed Text In Sidebar" items to a darker red and darker blue if a profile with white text is used.

So it's a usability issue when changing from a "light" theme to a "dark" theme, you need to also go into the "Diff" preferences and manually fix them. 

So, if the "Color of Added/Removed/Changed Text" in the Diff section is allowed to be overridden by the color theme chosen, then the "Background Color of Deleted/Changed Text In Sidebar" should also be able to be overridden, for a consistent look.

Comment 6 midnightlightning 2016-07-15 19:24:27 UTC

Though I should note I'm using NetBeans IDE 8.1 (Build 201510222201) when I say I'm still seeing the error. I'll see about getting the latest development version to test.