This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Allow annotating an icon of an arbitrary project type | ||
|---|---|---|---|
| Product: | projects | Reporter: | Tomas Mysik <tmysik> |
| Component: | Generic Projects UI | Assignee: | Tomas Stupka <tstupka> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | markiewb, tzezula |
| Priority: | P3 | Keywords: | API, PERFORMANCE |
| Version: | 6.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Bug Depends on: | 171516 | ||
| Bug Blocks: | 202592 | ||
| Attachments: | proposed fix | ||
[JG01] I guess these impls would be attached using @ProjectServiceProvider. Did you have a particular use case in mind? I cannot think of any. Project badges are generally either agnostic about project type, as for VCS or parser error marks; or part of a more complex warning UI managed by the project type and possibly already extensible via @PSP, as for o.n.m.maven.api.problem.ProblemReporter. [JG02] Use of the volatile modifier scares me, especially when applied to reference-typed fields. If some sort of thread safety is needed, monitors are usually called for to protect the internal state of the object. [JG03] Missing additions to ProjectUtilsTest.testAnnotateIcon. [JG04] Missing spec version change, apichanges.xml entry, Javadoc in PIA. Community contributions are always welcomed! Go on Tomáši! No current use cases; filed here in case it is useful in the future. Regarding JG01, would provide a better solution for bug #202592. The patch will not change any behavior of the issue #202592 but it improve performance (the JFXPIA will be loaded only for J2SEProjects). I will clean up the patch and integrate it in the NB 7.2. Sorry, did not get to this in time to file a review prior to 7.2 feature freeze. If this is, or is blocking, a DEFECT then let me know. It's not a blocker for NB 7.2. Reset invalid target milestone from 7.3 to TBD This old bug may not be relevant anymore. If you can still reproduce it in 8.2 development builds please reopen this issue. Thanks for your cooperation, NetBeans IDE 8.2 Release Boss |
Created attachment 101361 [details] proposed fix This enhancement is related to issue #171516. Maybe it could be sometimes useful to provide icon annotator for only a specific project type (at least for performance reasons). I'm attaching patch that might work. Feel free to review the patch, change it or simply close this issue if you think that it's useless. Thanks Jesse.