This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 205992

Summary: SPI to call org.netbeans.api.javahelp.Help.showHelp from NbPresenter
Product: platform Reporter: Jesse Glick <jglick>
Component: Help SystemAssignee: Jesse Glick <jglick>
Status: RESOLVED FIXED    
Severity: normal CC: apireviews, jhavlin, tpavek
Priority: P3 Keywords: API, API_REVIEW_FAST
Version: 7.1   
Hardware: All   
OS: All   
Issue Type: ENHANCEMENT Exception Reporter:
Attachments: Proposed patch

Description Jesse Glick 2011-12-06 13:02:57 UTC 

    


    


      



        
          Comment 1
        

        
          Jaroslav Tulach

        

        
        

        
          2011-12-06 13:40:04 UTC
        

      






Consider adding interface into existing

class HelpCtx {

  public static interface Presenter {
    public void showHelp(HelpCtx help);
  }

}

that would be used from all places that need to display a help.

    


    


      



        
          Comment 2
        

        
          Jesse Glick

        

        
        

        
          2011-12-06 14:46:41 UTC
        

      






Created attachment 113877 [details]
Proposed patch

    


    


      



        
          Comment 3
        

        
          Jesse Glick

        

        
        

        
          2011-12-06 14:47:45 UTC
        

      






Please review.

    


    


      



        
          Comment 4
        

        
          Tomas Pavek

        

        
        

        
          2011-12-06 15:22:05 UTC
        

      






Nice. It's amazing how many hacks and unneeded dependencies on JavaHelp can be eliminated by such a simple change.

Minor: Seems the patch is missing openide.util spec. version updated in:
core.windows/nbproject/project.xml

    


    


      



        
          Comment 5
        

        
          Jesse Glick

        

        
        

        
          2011-12-06 16:13:30 UTC
        

      






(In reply to comment #4)
> Seems the patch is missing openide.util spec. version updated in:
> core.windows/nbproject/project.xml

Good catch, will fix.

    


    


      



        
          Comment 6
        

        
          Jesse Glick

        

        
        

        
          2011-12-13 16:26:08 UTC
        

      






core-main #996035c0ad46

    


    


      



        
          Comment 7
        

        
          Quality Engineering

        

        
        

        
          2011-12-14 12:10:26 UTC
        

      






Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/996035c0ad46
User: Jesse Glick <jglick@netbeans.org>
Log: #205992: SPI to show a HelpCtx.