This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Adding @PropertyEditorRegistration and @PropertyEditorSearchPath annotations | ||
---|---|---|---|
Product: | platform | Reporter: | Jan Horvath <jhorvath> |
Component: | Nodes | Assignee: | Jan Horvath <jhorvath> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | apireviews, jglick, jlahoda |
Priority: | P3 | Keywords: | API_REVIEW_FAST |
Version: | 7.3 | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 210323, 220904 | ||
Attachments: |
diff
diff |
Description
Jan Horvath
2012-09-13 14:06:33 UTC
Created attachment 124317 [details]
diff
It is probably better to attach diff in plain format rather than gzipped. Thanks for fixing the usages in all the modules! I am sure module owners will be glad when they see your commit. Y01 You don't want to integrate -cluster.config=full +cluster.config=java clusters.prefix=libnb Y02 Javadoc of registerPropertyEditors is unfinished and is missing @since tag. Y03 Javadoc of PropertyEditorRegistration could refer to NodeOp#registerPropertyEditors. Same for PropertyEditorSearchPath Y04 Remove runtime dependency of Nodes on filesystems, enough to have just: <dependency> <code-name-base>org.openide.filesystems</code-name-base> <build-prerequisite/> <compile-dependency/> </dependency> Y05 Missing @since tag on the new annotation classes. Y06 I've noticed setBeanInfoSearchPath in xml.tax module. Do you plan to add @BeanInfoSearchPath? To Y01: use nbbuild/user.build.properties for local overrides. To Y06: cf. bug #210323. Y01 fixed Y02 fixed Y03 fixed Y04 fixed Y05 fixed Y06 I plan to implement @BeanInfoSearchPath next month Created attachment 124658 [details]
diff
I apologize, but I had to revert: http://hg.netbeans.org/jet-main/rev/08133c1ce9ad which is bringing this into jet-main. Not only it breaks ValidateLayerConsistencyTest.testInstantiateAllInstances: ------------ Some instances cannot be created File Services/PropertyEditorManager/Class-org-netbeans-beaninfo-editors-BoolEditor.instance should declare instanceOf File Services/PropertyEditorManager/Class-org-netbeans-beaninfo-editors-CharEditor.instance should declare instanceOf File Services/PropertyEditorManager/Class-org-netbeans-beaninfo-editors-IntEditor.instance should declare instanceOf File Services/PropertyEditorManager/Class-org-netbeans-beaninfo-editors-StringArrayEditor.instance should declare instanceOf File Services/PropertyEditorManager/Package-org-netbeans-beaninfo-editors.instance should declare instanceOf File Services/PropertyEditorManager/Package-org-netbeans-core-execution-beaninfo-editors.instance should declare instanceOf File Services/PropertyEditorManager/Package-org-netbeans-modules-xml-tax-beans-editor.instance should declare instanceOf File Services/PropertyEditorManager/Package-org-openide-explorer-propertysheet-editors.instance should declare instanceOf Log: ------------ but it also breaks the org.netbeans.beaninfo.editors.FindEditorTest. I could probably hotfix the VLCT, but not sure how to fix FET (I guess the test now requires generated-layer.xml to be available?). I apologize for inconvenience, but we need to ensure propagation of changes from jet-main. Please fix the tests and commit again (consider also using core-main, which may be more appropriate for this change). Revert changeset: http://hg.netbeans.org/jet-main/rev/04a12da60557 Integrated into 'main-golden', will be available in build *201209230001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/08133c1ce9ad User: Jan Horvath <jhorvath@netbeans.org> Log: #218300 - Adding @PropertyEditorRegistration and @PropertyEditorSearchPath annotations Thanks for the contribution and don't forget your @BeanInfoSearchPath promise... |