This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 233782

Summary:	[Refactoring>Inline] causes exception
Product:	java	Reporter:	ssazonov
Component:	Refactoring	Assignee:	Ralph Ruijs <ralphbenjamin>
Status:	VERIFIED FIXED
Severity:	normal	CC:	jiriprox, MackSix, muellermi, tboudreau
Priority:	P3
Version:	7.4
Hardware:	PC
OS:	Windows 7
Issue Type:	DEFECT	Exception Reporter:
Attachments:	exception Log stacktrace stacktrace

Description ssazonov 2013-08-01 13:07:48 UTC

Created attachment 138122 [details]
exception

According to test specification

http://wiki.netbeans.org/TS_74_Refactoring4
<Test suite: Inline - 1. Refactoring availability>

1. Put carret at position

public int add(int first, int second) { |       
    return first+second;
}


(where '|' is position of carret)

2. Rigt click and invoke Refactoring -> Inline

> You'll get exception (see attachemen)


Product Version: NetBeans IDE Dev (Build 201307312300)
Java: 1.7.0_25; Java HotSpot(TM) 64-Bit Server VM 23.25-b03
Runtime: Java(TM) SE Runtime Environment 1.7.0_25-b34
System: Linux version 3.8.0-19-generic running on amd64; UTF-8; en_US (nb)

Comment 1 ssazonov 2013-08-01 13:10:12 UTC

Created attachment 138123 [details]
Log

Comment 2 Jiri Prox 2013-08-05 08:34:02 UTC

*** Bug 233934 has been marked as a duplicate of this bug. ***

Comment 3 _ tboudreau 2013-08-20 22:25:04 UTC

Created attachment 138951 [details]
stacktrace

Attempting to inline a simple method which returns a field of another object.  Inlined method looks like:

    private BitSet activatedCells() {
        return snapshot.activatedCells;
    }

Comment 4 muellermi 2013-08-30 06:16:25 UTC

Created attachment 139466 [details]
stacktrace

click on refactor inline
BTW: where is the extract method refactoring?

Comment 5 Ralph Ruijs 2013-08-30 10:27:53 UTC

changeset   : ec408e67acf5
author      : Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
date        : Fri Aug 30 11:18:27 CEST 2013
summary     : #233782 - [Refactoring>Inline] causes exception

Comment 6 Quality Engineering 2013-09-01 01:25:54 UTC

Integrated into 'main-silver', will be available in build *201309010001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/ec408e67acf5
User: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
Log: #233782 - [Refactoring>Inline] causes exception

Comment 7 ssazonov 2013-09-17 11:54:15 UTC

Verified

Product Version: NetBeans IDE 7.4 RC1 (Build 201309152201)
Java: 1.7.0_40; Java HotSpot(TM) Client VM 24.0-b56
Runtime: Java(TM) SE Runtime Environment 1.7.0_40-b43
System: Windows 7 version 6.1 running on x86; Cp1252; en_US (nb)