Bug 241146

Sometimes you may find JSTL expressions within a javascript block that may build a static array for example. When this occurs it can confuse the javascript parser which causes it to then not format or recognize variables correctly even in function scope.

Consider the following:

  <script type="text/javascript">
    var widgetLinks = {
      <c:forEach var="ent" items="${requestScope['widgetLinks']}" varStatus="vs1">
        "${ent.key}": [
          <c:forEach varStatus="vs2" var="c" items="${ent.value}">${c.widgetId}${vs2.last ? '' : ','}</c:forEach>
        ]${vs1.last ? '' : ','}
      </c:forEach>
    };
  </script>

Forget the fact this looks ugly, note however that it because of `vs1.last' it causes the parser to go haywire.

Now I don't propose that this be fixed, I'm fine that it do this as it's complicated. What I am suggesting however, is that if it breaks within one script scope, that it does not affect other scripts. i.e. consider the following:

  <script type="text/javascript">
    // Above ugly block.
  </script>
  <script type="text/javascript">
    var doSomething = function(x) {
      return x + x * 3;
    );
    doSomething();
  </script>

In the above case, you can not rename, navigate references, or anything, within the second block. What I'm proposing is that each script block be treated semi-independently.

i.e. if a block exposes a global variable that can be identified, then that's all it should do. As soon as the script end tag is found the parser should not try and format anything going forward.



Product Version: NetBeans IDE Dev (Build 201401260001)
Java: 1.7.0_40; Java HotSpot(TM) 64-Bit Server VM 24.0-b56
Runtime: Java(TM) SE Runtime Environment 1.7.0_40-b43
System: Mac OS X version 10.9.1 running on x86_64; UTF-8; en_AU (nb)
User directory: /Users/bryan/Library/Application Support/NetBeans/dev
Cache directory: /Users/bryan/Library/Caches/NetBeans/dev