This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Get binary resources from ClassIndex | ||
|---|---|---|---|
| Product: | java | Reporter: | Ralph Ruijs <ralphbenjamin> |
| Component: | Source | Assignee: | Ralph Ruijs <ralphbenjamin> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | apireviews, sdedic, tzezula |
| Priority: | P2 | Keywords: | API, API_REVIEW_FAST |
| Version: | 8.1 | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://wiki.netbeans.org/FindUsagesDependencies | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Bug Depends on: | 253353 | ||
| Bug Blocks: | 55291 | ||
|
Description
Ralph Ruijs
2015-06-15 07:42:51 UTC
Please review the apichange on the find-in-dependencies branch. api: http://hg.netbeans.org/jet-main/rev/48a472537592 impl: http://hg.netbeans.org/jet-main/rev/4132bb5a8a0d TCA: The CI.getResources(...,sources) method may break project types like freeform. I will fix this.
TCR: The sources parameter is strange.
<cite>@param sources true if references should be from a source root</cite>
otherwise from what?
TCA: boolean API parameter is evil, related ti previous TCR. Consider to use Set<ResourceType> where enum ResourceType {SOURCE, BINARY}. There is already similar ClassIndexImpl.Type.
TCR: Is the method needed at all?
What the UI will do with usages for which the source is not found. The usage just tells that given class uses the type but it's unknown where and how many times the type is used (quite different from current Find Usages View).
(In reply to Tomas Zezula from comment #2) > TCA: The CI.getResources(...,sources) method may break project types like > freeform. I will fix this. Thanks! > TCR: The sources parameter is strange. > <cite>@param sources true if references should be from a source root</cite> > otherwise from what? > > TCA: boolean API parameter is evil, related ti previous TCR. Consider to use > Set<ResourceType> where enum ResourceType {SOURCE, BINARY}. There is already > similar ClassIndexImpl.Type. Added ResourceType enum to ClassIndex and updated the calls to it. http://hg.netbeans.org/jet-main/shortlog/9237e9736f51 > TCR: Is the method needed at all? > What the UI will do with usages for which the source is not found. The usage > just tells that given class uses the type but it's unknown where and how > many times the type is used (quite different from current Find Usages View). Yes :-) Knowing something is used and from which library/class gives a lot of information. It is different from the current Find Usages view as there are no class files in a project's source root. Adding support for dependencies changes this, as there are normally only class files in a dependency. Any more comments on the two TCRs? I'd like to integrate tomorrow. Thanks! Thanks Ralph. Fine for me, feel free to integrate. Fixed in jet-main 3384f2391053 & 6ee6524fa347 Integrated into 'main-silver', will be available in build *201506300001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/6ee6524fa347 User: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org> Log: #252992 - Get binary resources from ClassIndex |