Bug 267242

Created attachment 161370 [details]
IDE log

Created attachment 161371 [details]
before

Created attachment 161372 [details]
after

I'll need very precise steps to reproduce it; I've tried on current trunk and on the exact build (201607210002), but when I select "Math.floor(...)" subexpression, different thing happens.

I use Refactor > Introduce > Variable action. Is that the action you used ?

The initial (complete) source code is:

package test;
import java.text.DecimalFormat;
public class T {
  private void stuff() {
    Double l_amount = 2.0;
    System.out.println("l_amount=[" + l_amount + "]");
    if (l_amount != null) {
      String l_dollars = new DecimalFormat("0").format(Math.floor(l_amount));
      long l_cents = 0;
    }
  }
}

My result was:

package test;
import java.text.DecimalFormat;
public class T {
  private void stuff() {
    Double l_amount = 2.0;
    System.out.println("l_amount=[" + l_amount + "]");
    if (l_amount != null) {
          final double floor = Math.floor(l_amount);
      String l_dollars = new DecimalFormat("0").format(floor);
      long l_cents = 0;
    }
  }
}


Please try to isolate the problem into its own file/class. Attach that exact file and export your IDE options - some of the prettyprinter or formatting options may screw up offsets. You have some extra clusters (java2, javatextcopypaste) installed - I don't know whether they interfere. If possible, try to reproduce on a pristine IDE (whatever version from NB.org). Thanks !

I can no longer reproduce this on 201607260002.
Closing for now.

This problem is still present in 8.2 RC.  Yesterday this refactoring worked maybe 1 out of 5 times I tried it.  I'm working to get a repeatable test case, and disabling some of the plug ins.

I'm fairly certain that 256526, 257103 and 267242 all have the same root cause. There is some action I do regularly that messes up some internal table of line numbers in the Java source file with what is actually present in the editor. (My hypothesis.) Once in this state, Fix Imports, refactoring and error/hint icons are all messed up.  Closing the file and reopening it usually fixes the problem. 

How can I go about capturing what is needed to catch this?

I suspect that this, and several other of my bugs, may be caused by this: I had mapped Ctrl + V to "Paste Formatted". As an experiment, I put Ctrl + V back to a simple "Paste" and I have not seen these symptoms since.  I'll continue to watch. 

HTH

Sorry, still no luck. I tried the remapping but still I can't reproduce. 

Do you use shortcut (Alt-Shift-V), Alt-Enter + select the appropriate fix, or do you invoke the action by mouse only ?

See my recent notes in https://netbeans.org/bugzilla/show_bug.cgi?id=257103.

I think these are all related. 

The "paste formatted" was not the cause.  I turned it off and still have problems.