This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Rename package works incorrectly | ||
---|---|---|---|
Product: | editor | Reporter: | Jaromir Uhrik <juhrik> |
Component: | Refactoring | Assignee: | Jan Becicka <jbecicka> |
Status: | CLOSED FIXED | ||
Severity: | blocker | CC: | ehucka |
Priority: | P2 | ||
Version: | 4.x | ||
Hardware: | PC | ||
OS: | Windows ME/2000 | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 41535 |
Description
Jaromir Uhrik
2004-04-21 09:51:59 UTC
Should presumably be fixed as part of the PackageChildren rewrite. Petr please make sure there are *thorough* unit tests for this class. It is very important; and it should be simple to test it. Currently works as designed. We may change it later. However lowering to P3 - does not need change in APIs and has simple workaround. Go to files tab and rename the folder. Currently disabled *** Issue 43541 has been marked as a duplicate of this issue. *** OK the rename action was repaced by the refactoring operation but it seems to suffer the same bug. User is only allowed to rename the last part of the packagename. It is correct behavior. Rename refactoring of e.g. "org.openide.filesystems" to "com.tonda.franta.alois" is hardly definable operation. What to do with files in "org" package? What to do with files in "org.openide" package? Closing as wontfix. If you still request such feature, please reopen this issue as feature. *** Issue 45298 has been marked as a duplicate of this issue. *** I think you are not right Honza. If I have classes e.g. org.openide.fs.File, org.Data, org.openide.Main and I invoke Rename package refactoring on org.openide.fs (change to com.netbeans.fs) I assume that the class org.openide.fs.File will be repackaged (moved to com.netbeans.fs.File) and classes org.Data and org.openide.Main will stay as they are. It is easy. Packages "org" and "org.openide" don't have any logical association with "org.openide.fs". If we have fully logical view - Project View we should have fully logical actions on it. Users will be very confused. They will see full named package nodes and they can only change their "suffixies". Switching to file view is not solution. I can say to all editor bugs that workaround is to switch to plain text or to vi.:) Fixed. Checking in org/netbeans/modules/refactoring/api/Bundle.properties; /cvs/refactoring/src/org/netbeans/modules/refactoring/api/Bundle.properties,v <-- Bundle.properties new revision: 1.5; previous revision: 1.4 done Checking in org/netbeans/modules/refactoring/api/ChangeParameters.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/api/ChangeParameters.java,v <-- ChangeParameters.java new revision: 1.5; previous revision: 1.4 done Checking in org/netbeans/modules/refactoring/api/MoveClassRefactoring.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/api/MoveClassRefactoring.java,v <-- MoveClassRefactoring.java new revision: 1.7; previous revision: 1.6 done Checking in org/netbeans/modules/refactoring/api/RenameRefactoring.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/api/RenameRefactoring.java,v <-- RenameRefactoring.java new revision: 1.11; previous revision: 1.10 done Checking in org/netbeans/modules/refactoring/api/WhereUsedQuery.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/api/WhereUsedQuery.java,v <-- WhereUsedQuery.java new revision: 1.7; previous revision: 1.6 done Processing log script arguments... More commits to come... Checking in org/netbeans/modules/refactoring/api/ui/ParametersPanel.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/api/ui/ParametersPanel.java,v <-- ParametersPanel.java new revision: 1.10; previous revision: 1.9 done Processing log script arguments... More commits to come... Checking in org/netbeans/modules/refactoring/ui/RefactoringOperationListener.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/ui/RefactoringOperationListener.java,v <-- RefactoringOperationListener.java new revision: 1.6; previous revision: 1.5 done Checking in org/netbeans/modules/refactoring/ui/RenameAction.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/ui/RenameAction.java,v <-- RenameAction.java new revision: 1.8; previous revision: 1.7 done Checking in org/netbeans/modules/refactoring/ui/RenameRefactoringUI.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/ui/RenameRefactoringUI.java,v <-- RenameRefactoringUI.java new revision: 1.7; previous revision: 1.6 done Verified - in 200408161051; jdk1.5.0-rc-b63. v |