This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | [GTK] No Project badges in Open Project dialog | ||
|---|---|---|---|
| Product: | projects | Reporter: | Marian Mirilovic <mmirilovic> |
| Component: | Generic Projects UI | Assignee: | Petr Hrebejk <phrebejk> |
| Status: | CLOSED FIXED | ||
| Severity: | blocker | CC: | lkishalmi, tboudreau |
| Priority: | P3 | Keywords: | GTK |
| Version: | 4.x | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Bug Depends on: | |||
| Bug Blocks: | 41535 | ||
| Attachments: |
Screenshot - JDK1.5.0 (b49) GTK
Screenshot - JDK1.4.2_04 Sample of changing the file chooser UI Stacktrace of the NPE - JDK141_06 |
||
|
Description
Marian Mirilovic
2004-05-05 10:21:50 UTC
Created attachment 14715 [details]
Screenshot - JDK1.5.0 (b49) GTK
Created attachment 14716 [details]
Screenshot - JDK1.4.2_04
We've filed a high priority JDK bug to get this fixed for the GTK file chooser; I'll leave this issue open for now, so we know to do *something* (if there's anything we can do other than not supporting GTK L&F) for promo D. JDK b u g 5027268. Another suggestion made was to show a Metal file chooser, but using GTK-oriented icons if available. Not pleasant. JDK bug is that the GTK chooser shows no icons at all, it seems. The chooser will be rewritten in the future to follow a newer Gnome UI that does show icons, but that will probably come too late for us. Created attachment 14735 [details]
Sample of changing the file chooser UI
I will put in a patch to ProjectChooserAccessory to explicitly handle the case that ProjectFileView.getIcon is called but FileSystemView.getSystemIcon returns null (which is perfectly legal but which threw NPE before). For now, will just use a blank 16x16 as the base icon for folders, but could use a folder icon from the UIManager too. Then with an experimental proposed patch to the GTK L&F to display file icons if you request them (from FileView.getIcon I guess), it works OK. Will work around this somehow if it does not get handled in Tiger. Should leave this open until either the patch is put into a Tiger promotion and PCA is modified to use the UIManager's default folder icon as a fallback folder icon instead of empty.gif (if there is a default folder icon supplied in UIManager); or we put in the other workaround to use the Metal structure for the file chooser (with the GTK L&F for subcomponents). committed * Up-To-Date 1.6 projects/projectui/src/org/netbeans/modules/project/ui/ProjectChooserAccessory.java Installing the icon should be part of core/swing/plaf/gtk/GtkLFCustoms - just adding it into the array of key/value pairs it returns. Probably, unlike Leif's patch, we should provide an icon as an image and install it, rather than grabbing them from Metal/whatever. I don't know it should or not but it seems this patch causes NPE at Open Project in netbeans-4_0-daily-bin-200406291800-29_Jun_2004_1800.zip under OS/2 with Metal L&F. Created attachment 16075 [details]
Stacktrace of the NPE - JDK141_06
It's fixed in [nb_dev](200407281800) and [jdk1.5.0](b60) Thanks for the fix! NPE has gone on OS/2 and for a short test I've made NetBeans works again on JDK 1.4.1 and OS/2. I guess my patch to ProjectChooserAccessory.java: revision 1.19 date: 2004/07/27 04:12:02; author: jglick; state: Exp; lines: +6 -0 Fixing obscure NPE. might have fixed Leslie's stack trace, though that is not the reason I encountered it. Since AFAIK the badges appear on GTK now, I think this can be closed. BTW Leslie, thanks for reporting bugs on OS/2! verified in [nb_dev](200408081800) |