This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
|Summary:||Cannot use 'inplace' rename on method|
|Product:||java||Reporter:||Marek Grummich <mgrummich>|
|Component:||Unsupported||Assignee:||Jan Becicka <jbecicka>|
|Issue Type:||DEFECT||Exception Reporter:|
|Bug Depends on:||53295|
Description Marek Grummich 2004-06-22 14:08:52 UTC
Build 200406211800, JDK 1.4.2 Steps to reproduce: 1) Invoke 'inplace' rename on some method 2) Enter new name, hit Enter 3) Name isn't changed - old name is displayed for node; no refactoring action (rename) is invoked
Comment 1 Martin Matula 2004-06-22 14:30:14 UTC
Honzo, could you please disable inplace rename on these nodes the same way it is done for package nodes in project view?
Comment 2 Milan Kubec 2004-06-22 14:45:31 UTC
Is really disabling of a broken feature the correct way of fixing it? Please append comment from HIE person approving disabling of the feature. Thanks.
Comment 3 Jan Pokorsky 2004-06-22 14:51:34 UTC
disabling of a broken feature? What is broken? Plain rename was replaced with refactoring rename. fixed in /cvs/java/src/org/netbeans/modules/java/ui/nodes/elements/MethodNode.java,v <-- MethodNode.java new revision: 1.5; previous revision: 1.4
Comment 4 Milan Kubec 2004-06-22 15:08:19 UTC
Well, we need to start a discussion here. I don't consider disabling the feature as fix. Please point me to some UI specification that says that there will be no other rename gesture than context menu Refactor | Rename. Inplace rename is well-known wide-spread rename gesture and it's being disabled. The broken feature is 'inplace rename'.
Comment 5 Milan Kubec 2004-06-22 15:13:42 UTC
Please Dusane, could you comment on this? Thanks.
Comment 6 Martin Matula 2004-06-22 15:42:38 UTC
Just a note - the same approach is taken for the package nodes. In-place rename is common when it really means just rename - a simple operation. Refactoring should not be a simple action (like in-place editing) since it potentially affects a lot of other sources. AFAIK, the UI team wants to remove the nodes below the file node anyway and outline views are usually read-only.
Comment 7 Milan Kubec 2004-06-22 15:58:02 UTC
Of course that refactoring is complex process affecting other sources, but does user care about it if he wants just rename simple java file the way he was used to in previous release? UI team wants to have outline view in promo D?
Comment 8 Martin Matula 2004-06-22 16:15:24 UTC
Nobody talks about renaming a single java file - that still works. Anyway, let me lower the priority to P3, now that the IDE does not behave erroneously and let's keep this issue open to discuss whether the original decision to disable in-place rename was correct or not.
Comment 9 Milan Kubec 2004-06-23 07:46:36 UTC
Well, I meant method rename, of course.
Comment 10 Jan Becicka 2004-09-21 13:46:36 UTC
It is impossible to reduce Rename Refactoring UI into inplace rename of method IMO. I don't know any IDE allowing that. But this is my personal opinion. Dusane, can answer Milan? Thanks
Comment 11 dpavlica 2004-10-26 11:55:14 UTC
Inplace renaming works for package and java file currently. Logically it should work for methods, fields and constructors too in my opinion.
Comment 12 Jan Becicka 2004-10-26 12:30:17 UTC
Behavior of inplace refactoring in not specified. Please add it to a refactoring ui spec. Issues: Regular refactoring does prechecks, before user is allowed to set new parameters. When should be these prechecks done? Where should be result of prechecks displayed? Should inplace rename invoke any dialog? Note: Rename of file and package is already specified.
Comment 13 dpavlica 2004-10-26 13:01:12 UTC
Inplace Rename of file, methods, fields is mentioned in this spec (Rename chapter and figure 4 for file): http://ui.netbeans.org/docs/hi/javamdr/refactoring_design.html Only one detail will be changed against figure 4...Use "Method" string instead of "File" text in the title of dialog. Does it have sense for you?
Comment 14 Jan Becicka 2004-10-26 13:09:18 UTC
Yes you are right, it is mentioned there. Sorry, I didn't see it.
Comment 15 Jan Becicka 2005-01-12 14:00:47 UTC
We are unable to implement it with current API.
Comment 16 Jan Becicka 2007-06-28 17:14:51 UTC
Method nodes removed from explorer. This issue is not valid any more.