This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 46620

Summary: Use String.intern() for file attribute names in BinaryFS
Product: platform Reporter: _ rkubacki <rkubacki>
Component: -- Other --Assignee: Petr Nejedly <pnejedly>
Status: CLOSED FIXED    
Severity: blocker CC: issues
Priority: P4 Keywords: PERFORMANCE, SIMPLEFIX
Version: 4.x   
Hardware: PC   
OS: All   
Issue Type: ENHANCEMENT Exception Reporter:

Description _ rkubacki 2004-07-27 16:50:26 UTC
o.n.core.projects.cache.BinaryFS$BFSBase.initialize
can intern strings read as a name of file
attribute (these strings should be in pool anyway
because they are used as literals somewhere if
they make sense).

With simple project opened in my dev build I see
couple of them referenced mostly from binary FS only:
132 instances of 'originalFile', 34 'instanceOf',
45 'instanceCreate', 118 'instanceClass', 66
'SystemFileSystem.icon', 99
'SystemFileSystem.localizingBundle'. How much is
it? 20-30kB perhaps.
Comment 1 _ rkubacki 2004-07-27 17:13:49 UTC
But I am not sure about attrs for file ordering.
Comment 2 _ rkubacki 2004-07-27 17:42:26 UTC
re file ordering - maybe we should not intern it for string containing
/. OTOH there are some duplicates too (like the same order of items in
toolbar as in menu for Cut vs. Copy actions).
Comment 3 Petr Nejedly 2004-07-28 13:07:16 UTC
How could I forget about this... ?
Thanks for noticing
Comment 4 Petr Nejedly 2004-12-25 18:08:47 UTC
Forgot to mark as fixed.
Interning added in BinaryFS.java,v1.13, on 2004/09/23 and made it into
4.0 release.
Comment 5 Marian Mirilovic 2005-12-20 15:50:55 UTC
This issue was solved long time ago. Because nobody has reopened it neither
added comments, we are verifying/closing it now. 
If you are still able to reproduce the problem, please reopen. Thanks in advance.