This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 47451

Summary: [40cat] Nodes collapsed when changing properties - SourcesHelper must fire minimal changes
Product: projects Reporter: Milan Kubec <mkubec>
Component: AntAssignee: Jesse Glick <jglick>
Status: CLOSED FIXED    
Severity: blocker CC: lleland
Priority: P3 Keywords: PERFORMANCE
Version: 4.x   
Hardware: PC   
OS: Linux   
Issue Type: DEFECT Exception Reporter:
Bug Depends on:    
Bug Blocks: 41535, 47910    

Description Milan Kubec 2004-08-19 11:26:13 UTC 
[beta 1 candidate 200408181510, JDK 1.5.0 b63]

Source Packages and Test Packages nodes get
collapsed when project properties are changed.
Comment 1 Marian Mirilovic 2004-08-19 12:44:41 UTC 
seems like dup of issue 47402
Comment 2 Petr Hrebejk 2004-08-19 13:23:48 UTC 
Unfortuanately it is not. It looks like if one closes the project
customizer using OK button. The whole project view closes. I don't
know why but I will look at it.
Comment 3 Jesse Glick 2004-08-19 18:24:59 UTC 
Maybe excess firing from SourcesHelper? If so, reassign to me for
evaluation.
Comment 4 Petr Hrebejk 2004-08-20 11:16:37 UTC 
I suspect the LogicalViewChildren to get some events from
SourcesHeleper even after the project is closed (it of course does not
matter until someone deleted all the files). When the files are
deleted the SourceHeleper fires a change and LogicalViewChildren try
to react. The children would have to know that the project was closed
(GC may be too late). Listen to OpenProjects in projectuiapi?
Comment 5 Petr Hrebejk 2004-08-20 11:17:54 UTC 
Opps, ignore the last comment it was about another issue.
Comment 6 Petr Hrebejk 2004-08-21 11:59:11 UTC 
Hmm, Jesse you asked for it. It seems that the Sources implementation
fires StateChanged even if no change was made to it (which forces the
chilren to set keys). It is enogh to change something like Compress
Jar file and pres OK in the project customizer to trigger that event.
Comment 7 Jesse Glick 2004-08-21 17:18:54 UTC 
OK, I will try to avoid firing changes unless they are necessary -
just compare old to new state.
Comment 8 Jesse Glick 2004-08-25 00:13:01 UTC 
*** Issue 47782 has been marked as a duplicate of this issue. ***
Comment 9 Jesse Glick 2004-08-26 05:27:19 UTC 
Has a performance impact too, apparently.
Comment 10 Jesse Glick 2004-08-27 22:16:22 UTC 
*** Issue 48054 has been marked as a duplicate of this issue. ***
Comment 11 lleland 2004-08-27 23:08:29 UTC 
Marked for the NetCat40 process.
Comment 12 Jesse Glick 2004-09-13 15:27:51 UTC 
*** Issue 48884 has been marked as a duplicate of this issue. ***
Comment 13 Jesse Glick 2004-09-16 03:31:26 UTC 
committed   * Up-To-Date  1.9        
ant/project/src/org/netbeans/spi/project/support/ant/SourcesHelper.java
committed   * Up-To-Date  1.7        
ant/project/test/unit/src/org/netbeans/spi/project/support/ant/SourcesHelperTest.java
Comment 14 Milan Kubec 2004-10-01 15:09:59 UTC 
Verified in custom 20041001.
Comment 15 Jesse Glick 2004-10-27 00:22:50 UTC 
*** Issue 50531 has been marked as a duplicate of this issue. ***