This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
|Summary:||Allow tabs to request attention (flash, etc.)|
|Product:||platform||Reporter:||_ tboudreau <tboudreau>|
|Component:||Window System||Assignee:||Milos Kleint <mkleint>|
|Severity:||blocker||CC:||dsimonek, mkleint, tboudreau, tfast|
|Issue Type:||DEFECT||Exception Reporter:|
|Bug Depends on:|
|Bug Blocks:||19631, 49693|
Implementation of "flashing" tabs on the 4.0 tab control w/ heavy unit tests; also some bug fixes found while writing the tests
Backport of the 4.0 window system to 3.6 (test heavily if you want to use it!)
Blinking tab patches (improved) + integration into window system & API for 4.0
Window system backport to 3.6 with blinking tabs code
apichanges for openide
Description _ tboudreau 2004-09-10 00:38:01 UTC
Requested by the Bow team: Provide a way to make tabs "flash" or otherwise request the user to click on them, for use in collborative/messaging environments.
Comment 1 _ tboudreau 2004-09-10 00:39:09 UTC
Created attachment 17538 [details] Implementation of "flashing" tabs on the 4.0 tab control w/ heavy unit tests; also some bug fixes found while writing the tests
Comment 2 _ tboudreau 2004-09-10 00:41:07 UTC
I'm tempted to integrate this, given that the "flashing" code path will not be used by NetBeans 4.0, and the additional tests and bug fixes (a couple off-by-one errors in the data model when using add/remove methods the window system doesn't normally use) are worthwhile. But since it's late in the 4.0 game, this should probably wait for 4.1.
Comment 3 _ tboudreau 2004-09-10 03:04:23 UTC
Created attachment 17539 [details] Backport of the 4.0 window system to 3.6 (test heavily if you want to use it!)
Comment 4 _ tboudreau 2004-09-10 19:59:48 UTC
Created attachment 17564 [details] Blinking tab patches (improved) + integration into window system & API for 4.0
Comment 5 _ tboudreau 2004-09-10 20:01:49 UTC
The last patch adds the following methods to TopComponent: public void requestAttention (boolean brief); //if brief, it will blink a few times and stop public void cancelRequestAttention(); and the following methods to WindowManager: protected void topComponentRequestAttention(); protected void topComponentCancelRequestAttention(); and blinking is also implemented for sliding buttons.
Comment 6 _ tboudreau 2004-09-10 21:38:11 UTC
Created attachment 17565 [details] Window system backport to 3.6 with blinking tabs code
Comment 7 _ tboudreau 2004-09-15 10:36:47 UTC
Assigning to API reviews - might as well get a head start on this, so once the trunk is branched for 4.0 release, it can be committed.
Comment 8 Jaroslav Tulach 2004-09-15 12:39:26 UTC
I can confirm that this is really heavy tested. I have no comments about the functionality, I believe that it works and I am sure that this will be maintainable in future. I just want few more improvements in documentation. Please mention this in: 1. set of usecases in http://www.netbeans.org/download/dev/javadoc/TabbedContainerAPI/architecture-summary.html 2. set of usecases of windowsystem arch*.xml 3. create apichanges document for TabbedContainerAPI and update it 4. update window system apichanges
Comment 9 _ tboudreau 2004-09-15 13:42:51 UTC
> I just want few more improvements in documentation. Please mention > this in... No problem with doing that - but I've learned my lesson with including docs patches in code patches - inevitably someone adds some other change before the issue is committed, breaking the diff, and you have to keep fixing the patch to keep up with arch or apichanges docs. So no problem to do this, but if you don't mind I'd rather integrate the code, then add the documentation.
Comment 10 Milos Kleint 2004-11-16 10:00:07 UTC
what is the status of this review? I assume it's approved and just waiting to be integrated. Since Tim is no longer on the winsys/ui team, I guess I'm taking over.
Comment 11 Milos Kleint 2004-11-16 14:59:36 UTC
Created attachment 18924 [details] apichanges for openide
Comment 12 Milos Kleint 2004-11-18 14:29:52 UTC
integrated into trunk. increased version of openide+core/tabcontrol added apichanges entries.
Comment 13 _ tboudreau 2004-11-19 03:06:05 UTC
Thanks for doing that, Milos - I was wondering this week if I should step in and go ahead and integrate this :-)
Comment 14 Jaroslav Tulach 2004-11-19 09:46:21 UTC
I would suggest to make the WindowManager methods non-abstact and empty. It hurts nobody and makes 4.0 and 4.1 at least binary compatible.
Comment 15 Milos Kleint 2004-11-19 12:56:49 UTC
ok, it's quite unlikely that soneone would attempt to implement his/her own window system but generaly it's ok with me to make it non-abstract.
Comment 16 Milos Kleint 2004-11-22 09:15:53 UTC
done, Windowmanager has the new methdos as non-abstract.
Comment 17 _ tboudreau 2005-07-19 19:30:09 UTC