This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | [50cat] Commit should be enabled if at least one of the items selected has changed | ||
---|---|---|---|
Product: | versioncontrol | Reporter: | misterm <misterm> |
Component: | CVS | Assignee: | issues@versioncontrol <issues> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | jkovalsky, jrojcek, pkeegan, tmulligan |
Priority: | P3 | Keywords: | UI |
Version: | 5.x | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
misterm
2005-10-21 15:19:09 UTC
Switching to defect. I agree with Michael. I don't care if this is implemented as designed, it's a defect, unless someone can convince me that most people really would prefer a different workflow to commit changes to a multi-file node. I do not know for the whole IDE, but CVS actions are enabled on a selection of files only if they are enabled for every single file in the selection. Here we try co make Commit an exception (others will follow?). HIE, can you please comment on this? To add my point of view, I understand the idea to count enabled actions as intersection based on all nodes but IDE should help developer and not teach him/her logic. Other thing that occur, is that you just change the .java file with has a .form file too. The tab page for this file and node appear with blue color, but the "Commit" action is disabled. I can simulate these problem with .properties files too. If I just change one of all Locales of this properties file, the "Commit" action is disabled too. Commit, Diff, Resolve Conflicts and Revert Modifications actions are now enabled only if they will have some files to process when invoked on the selected context. This means that these actions will now be enabled on Project nodes only if there really are some modified (or conflicting) files inside the project. This also means that Commit/Diff/Revert will be enabled if users select 10 files and only one of them is modified. /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/diff/ResolveConflictsAction.java,v <-- ResolveConflictsAction.java new revision: 1.9; previous revision: 1.8 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/diff/DiffAction.java,v <-- DiffAction.java new revision: 1.15; previous revision: 1.14 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/update/GetCleanAction.java,v <-- GetCleanAction.java new revision: 1.21; previous revision: 1.20 /shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/commit/CommitAction.java,v <-- CommitAction.java new revision: 1.23; previous revision: 1.22 |