This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Additional Completion SPI changes | ||
---|---|---|---|
Product: | editor | Reporter: | Miloslav Metelka <mmetelka> |
Component: | Completion & Templates | Assignee: | Miloslav Metelka <mmetelka> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | Keywords: | API, API_REVIEW_FAST |
Priority: | P4 | ||
Version: | 5.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
Completion SPI diff
Updated diff |
Description
Miloslav Metelka
2005-11-07 16:45:56 UTC
Created attachment 26706 [details]
Completion SPI diff
As the changes are minor I would like to ask for fasttrack review. Look OK to me. "summary>Editor Code Completion API created</summary>" is probably wrong. Maybe you want three different apichanges as the changes are independent. I do not understand the meaning of the first change as that modifies something in a call-flow which is not described anywhere. I believe that (especially because it is asynchronous) it should have a test coverage. To verify the behaviour and also show the intended call-flow. I don't have any objections. I hope, that the appropriate changes in jsp editor will be done. Thanks to all for reviewing and comments. I have fixed the apichanges name and I've made three apichanges so the final version is 1.5. I will integrate the change but I'll leave the issue opened until we finish the tests. Created attachment 26713 [details]
Updated diff
Fixed in trunk: Checking in editor/codetemplates/src/org/netbeans/lib/editor/codetemplates/CodeTemplateCompletionItem.java; /cvs/editor/codetemplates/src/org/netbeans/lib/editor/codetemplates/CodeTemplateCompletionItem.java,v <-- CodeTemplateCompletionItem.java new revision: 1.11; previous revision: 1.10 done Checking in editor/completion/apichanges.xml; /cvs/editor/completion/apichanges.xml,v <-- apichanges.xml new revision: 1.2; previous revision: 1.1 done Checking in editor/completion/manifest.mf; /cvs/editor/completion/manifest.mf,v <-- manifest.mf new revision: 1.4; previous revision: 1.3 done Checking in editor/completion/src/org/netbeans/modules/editor/completion/CompletionImpl.java; /cvs/editor/completion/src/org/netbeans/modules/editor/completion/CompletionImpl.java,v <-- CompletionImpl.java new revision: 1.26; previous revision: 1.25 done Checking in editor/completion/src/org/netbeans/modules/editor/completion/CompletionResultSetImpl.java; /cvs/editor/completion/src/org/netbeans/modules/editor/completion/CompletionResultSetImpl.java,v <-- CompletionResultSetImpl.java new revision: 1.5; previous revision: 1.4 done Checking in editor/completion/src/org/netbeans/spi/editor/completion/CompletionItem.java; /cvs/editor/completion/src/org/netbeans/spi/editor/completion/CompletionItem.java,v <-- CompletionItem.java new revision: 1.4; previous revision: 1.3 done Checking in editor/completion/src/org/netbeans/spi/editor/completion/CompletionResultSet.java; /cvs/editor/completion/src/org/netbeans/spi/editor/completion/CompletionResultSet.java,v <-- CompletionResultSet.java new revision: 1.4; previous revision: 1.3 done Checking in editor/completion/src/org/netbeans/spi/editor/completion/CompletionTask.java; /cvs/editor/completion/src/org/netbeans/spi/editor/completion/CompletionTask.java,v <-- CompletionTask.java new revision: 1.5; previous revision: 1.4 done Checking in editor/completion/src/org/netbeans/spi/editor/completion/support/AsyncCompletionQuery.java; /cvs/editor/completion/src/org/netbeans/spi/editor/completion/support/AsyncCompletionQuery.java,v <-- AsyncCompletionQuery.java new revision: 1.4; previous revision: 1.3 done Checking in editor/completion/src/org/netbeans/spi/editor/completion/support/AsyncCompletionTask.java; /cvs/editor/completion/src/org/netbeans/spi/editor/completion/support/AsyncCompletionTask.java,v <-- AsyncCompletionTask.java new revision: 1.4; previous revision: 1.3 done Checking in java/editor/src/org/netbeans/modules/editor/java/ElementCreatingCompletionProvider.java; /cvs/java/editor/src/org/netbeans/modules/editor/java/ElementCreatingCompletionProvider.java,v <-- ElementCreatingCompletionProvider.java new revision: 1.7; previous revision: 1.6 done Checking in java/editor/src/org/netbeans/modules/editor/java/JavaCompletionProvider.java; /cvs/java/editor/src/org/netbeans/modules/editor/java/JavaCompletionProvider.java,v <-- JavaCompletionProvider.java new revision: 1.13; previous revision: 1.12 done Checking in java/editor/src/org/netbeans/modules/editor/java/NbJMIResultItem.java; /cvs/java/editor/src/org/netbeans/modules/editor/java/NbJMIResultItem.java,v <-- NbJMIResultItem.java new revision: 1.35; previous revision: 1.34 done Checking in html/editor/lib/src/org/netbeans/editor/ext/html/HTMLCompletionQuery.java; /cvs/html/editor/lib/src/org/netbeans/editor/ext/html/HTMLCompletionQuery.java,v <-- HTMLCompletionQuery.java new revision: 1.24; previous revision: 1.23 done Checking in web/jspsyntax/src/org/netbeans/modules/web/core/syntax/completion/JspCompletionItem.java; /cvs/web/jspsyntax/src/org/netbeans/modules/web/core/syntax/completion/JspCompletionItem.java,v <-- JspCompletionItem.java new revision: 1.10; previous revision: 1.9 I will continue to work on the tests. Old target milestone, please reevaluate I will add the test coverage to the trunk. So, have we got the tests already? Is it still valid? P2? I think we should close this one. It's about missing tests. The change has already been in trunk for ages. Milo, if you have the tests ready, please check them in. If not, never mind and close it. Adding more tests is a continuous effort anyway. OK. Marking as fixed since the completion spi changes were implemented. |