This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | extra space in common.xml template | ||
---|---|---|---|
Product: | apisupport | Reporter: | luky <luky> |
Component: | Harness | Assignee: | Jesse Glick <jglick> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | rbalada, rnovak |
Priority: | P2 | Keywords: | SIMPLEFIX |
Version: | 5.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | Patch to remove extra trailing space |
Description
luky
2005-12-12 16:15:13 UTC
Well I will fix but I am curious why only you observe this as a bug. The extra space is certainly unintentional, but it should work anyway: <mkdir dir="${build.test.unit.results.dir}"/> is called right before the failing line. Did you perhaps override ${test.report.file}? committed Up-To-Date 1.28 nbbuild/templates/common.xml Created attachment 27777 [details]
Patch to remove extra trailing space
This issue certainly affects products build on top of NetBeans binary and their own test suites, thus raising priority to P2 to meet criteria for checkin into 'release50' branch in High Resistance. I've attached a patch for Jesse's change. I would like to apply that patch in release50 branch. The patch is simple and safe. I'll request reviewers@netbeans.org to let the patch go into branch. If it would get approved, I'll update target milestone of this issue to '5.0'. I check the patch and it is indeed simple (and correct) enough. I don't know why this problem surfaced just now. As I said, it use to work, and it starts to happen after the last update. Probably some code change on higher level I check the patch and it is indeed simple (and correct) enough. I don't know why this problem surfaced just now. As I said, it use to work, and it starts to happen after the last update. Probably some code change on higher level verified for trunk luky: I would appreciate some investigation into why the pre-patch code was failing for you. Did the <mkdir/> not work correctly? Does <junit> somehow fail with certain kinds of paths? What does ant -v report as the exact location of the error? While the "results " dir name was of course unintentional, it should not have caused an error like this, and as far as I know did not cause this error for anyone else, so I would like to know what was special in your case; there may be an unreported bug in some other component (perhaps Ant). Fix merged to 'release50' branch. Luky please verify with Thursday morning Mobility Pack build. $ cvs ci -m "Issue 70284 removed extra space in path definition. Merged fix fro m trunk." nbbuild/templates/common.xml Checking in nbbuild/templates/common.xml; /cvs/nbbuild/templates/common.xml,v <-- common.xml new revision: 1.27.4.1; previous revision: 1.27 done Was broken for quite a while, actually; typo during rewrite of properties: revision 1.10 date: 2005/06/27 09:53:28; author: jskrivanek; state: Exp; lines: +23 -4 Added do-test-build to be called from xtest; copy data/** to ${build.test.unit.dir} in targets do-test-build and compile-test-single. No exact steps to reproduce, don't know how to verify:( luky: could you verify also in 5.0 branch?? thanks in adavnce! Still awaiting investigation from luky - cf. my comments of Dec 13. |