This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 71355

Summary: jdom module from feedreader doesn't contain license
Product: usersguide Reporter: pzajac <pzajac>
Component: API SupportAssignee: Martin Krauskopf <mkrauskopf>
Status: VERIFIED FIXED    
Severity: blocker CC: jchalupa, mkleint, mmirilovic
Priority: P1 Keywords: SIMPLEFIX
Version: 5.x   
Hardware: All   
OS: All   
Issue Type: DEFECT Exception Reporter:
Bug Depends on: 119268    
Bug Blocks:    

Description pzajac 2006-01-13 11:39:12 UTC
Nb50 RC1
Steps to reproduce:
1) Create FeadReader example template
2) Look to project properties of jdom module

The license.txt file is defined in settings but is not presented in project files.
Comment 1 Martin Krauskopf 2006-01-13 12:10:24 UTC
Why me? :)

Anyway I don't know if the fix should:

* either add a LICENSE.txt to a jdom module
* or remove the property, i.e. no license is needed

Anybody know?
BTW if you have the reason for this to be a P1 please note it here, not in
private email ;).... NBM cannot be built Petr says.
Comment 2 Jan Chalupa 2006-01-13 12:17:28 UTC
Martin, please add LICENSE.txt to the jdom module.

Why wasn't this discovered earlier? NBM cannot be built? Has it always been the
case? I was able to build the FeedReader sample without problems several weeks
ago. Has anything changed recently?
Comment 3 pzajac 2006-01-13 12:17:29 UTC
Why you? You already fixed few issues for feedreader. You are experienced
feedreader developer :-)

The license is set only for jdom. I doesn't understand why other modules don't
have license. 
Comment 4 Tomas Danek 2006-01-13 12:30:45 UTC
> I was able to build the FeedReader sample without problems several weeks
ago.

you are able to build all in Feedreder suite,and also create ZIP distrubution.
This is visible only when you try to build NBM on jdom module (what is the
motivation for doing this?!) or when you open its properties (reasonable)
Comment 5 Marian Mirilovic 2006-01-13 12:52:40 UTC
> Martin, please add LICENSE.txt to the jdom module.

BTW: Is it legal to distribute these modules without licence? I think this is P1
for NB 5.0.

> Why wasn't this discovered earlier?
Good question and we have to think about it.
Comment 6 Martin Krauskopf 2006-01-13 13:03:10 UTC
Ok, I'll add licenses to all three modules.
Comment 7 Tomas Danek 2006-01-13 13:06:13 UTC
FYI... I've filed P3 issue 71360 also concerning Feedreader. Consider changing
priority.
Comment 8 Martin Krauskopf 2006-01-13 13:26:46 UTC
Fixed. Milosi could you review? Thanks.

Checking in feedreader-sample-ui/build.xml;
new revision: 1.5; previous revision: 1.4
Checking in feedreader-suite/jdom/nbproject/project.properties;
new revision: 1.2; previous revision: 1.1
Checking in feedreader-suite/rome/nbproject/project.properties;
new revision: 1.2; previous revision: 1.1
Checking in feedreader-suite/rome-fetcher/nbproject/project.properties;
new revision: 1.2; previous revision: 1.1
Comment 9 Martin Krauskopf 2006-01-13 13:35:05 UTC
For convenience:

http://apisupport.netbeans.org/servlets/ReadMsg?list=cvs&msgNo=3083
Comment 10 Milos Kleint 2006-01-13 13:42:47 UTC
fix looks good. 
Comment 11 Jesse Glick 2006-01-13 16:28:54 UTC
Looks good to me too. QA can verify by:

- making FR sample suite

- building it

- creating NBMs from each member module

- running a fresh copy of the platform (e.g. downloaded)

- run AU wiz, add set of FR NBMs

- verify that reasonable licenses are shown

- verify that all modules installed and work
Comment 12 pzajac 2006-01-16 09:52:13 UTC
verified in trunk
Comment 13 Martin Krauskopf 2006-01-16 12:33:39 UTC
Backported also into release50.
Comment 14 Tomas Danek 2006-01-16 16:27:07 UTC
verified all theese steps also in 5.0 branch - verified.
Comment 15 Tomas Danek 2006-01-16 16:33:17 UTC
btw feedreeder module itself has no license.txt, but suppose it does not matter..