This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 74855

Summary:	Add an API for opening the Options dialog
Product:	platform	Reporter:	Sherold Dev <sherold>
Component:	Options&Settings	Assignee:	rmatous <rmatous>
Status:	RESOLVED FIXED
Severity:	blocker	CC:	anebuzelsky, jrechtacek, rmatous, tor, vstejskal, vv159170
Priority:	P2	Keywords:	API, API_REVIEW_FAST
Version:	5.x
Hardware:	All
OS:	All
Issue Type:	ENHANCEMENT	Exception Reporter:
Bug Depends on:
Bug Blocks:	64350, 75856, 91331
Attachments:	Suggested API + test modified according to comments

Description Sherold Dev 2006-04-11 14:52:00 UTC

Add an API for opening the Options dialog. Being able to specify the category
that should be preselected would be desirable.

Currently there are several places from where you can edit proxy settings:
auto-update, web services client wizard, cvs support and each from this places
uses its own proxy setting dialog even if there is already one in the Options
dialog.

We would like to allow to set the proxy parameters also from the server
customizers in the server manager, but since we do not want to introduce new
instances of proxy form dialogs we would like to open the proxy form in the
Options dialog instead.

Comment 1 rmatous 2006-12-07 14:03:40 UTC

*** Issue 64350 has been marked as a duplicate of this issue. ***

Comment 2 rmatous 2006-12-13 11:47:45 UTC

Created attachment 36638 [details]
Suggested API + test

Comment 3 Jesse Glick 2006-12-13 16:04:13 UTC

Not clear what the call to SwingUtilities.invokeAndWait is good for, if you are
anyway using Mutex.EVENT.readAccess. If you do need this call, please document
that fact, since it is dangerous (deadlock-prone).


Boolean retval = Mutex.EVENT.readAccess(new Mutex.Action<Boolean> () {
  public Boolean run() {
    // ...
    return Boolean.valueOf(retvalForRun);
  }
});
return retval;

can be simplified to

return Mutex.EVENT.readAccess(new Mutex.Action<Boolean> () {
  public Boolean run() {
    // ...
    return retvalForRun;
  }
});


Missing @since and spec vers increment.

Comment 4 Vitezslav Stejskal 2006-12-13 18:52:03 UTC

I don't think Logger.log() methods permit passing null as the msg parameter.

Comment 5 Jesse Glick 2006-12-13 19:12:13 UTC

log.log(Level.SEVERE, null, ex);

is fine (check LogRecord constructor), though it is a bit easier to call
Exceptions.printStackTrace.

Comment 6 rmatous 2006-12-14 10:41:38 UTC

Created attachment 36663 [details]
modified according to comments

Comment 7 rmatous 2006-12-19 15:00:25 UTC

/cvs/core/options/src/org/netbeans/modules/options/Utils.java,v  <--  Utils.java
new revision: 1.6; previous revision: 1.5

/cvs/core/options/src/org/netbeans/modules/options/OptionsPanel.java,v  <--  new
revision: 1.40; previous revision: 1.39

/cvs/core/options/src/org/netbeans/modules/options/OptionsDisplayerImpl.java,v 
initial revision: 1.1

/cvs/core/options/src/org/netbeans/modules/options/CategoryModel.java,v  <-- 
new revision: 1.4; previous revision: 1.3

/cvs/core/options/src/org/netbeans/modules/options/OptionsWindowAction.java,v 
new revision: 1.34; previous revision: 1.33

/cvs/core/options/apichanges.xml,v  <--  apichanges.xml
new revision: 1.5; previous revision: 1.4

/cvs/core/options/manifest.mf,v  <--  manifest.mf
new revision: 1.9; previous revision: 1.8

/cvs/core/options/test/unit/src/org/netbeans/api/options/OptionsDisplayerOpenTest.java,v
 initial revision: 1.1

/cvs/core/options/test/unit/src/org/netbeans/api/options/RegisteredCategory.java,v
 initial revision: 1.1

/cvs/core/options/test/unit/src/org/netbeans/api/options/mf-layer.xml,v  <-- 
initial revision: 1.1

/cvs/core/options/test/unit/src/org/netbeans/api/options/IDEInitializer.java,v 
initial revision: 1.1

/cvs/core/options/test/build.xml,v  <--  build.xml
initial revision: 1.1

/cvs/core/options/test/cfg-unit.xml,v  <--  cfg-unit.xml
initial revision: 1.1

/cvs/core/options/test/build-unit.xml,v  <--  build-unit.xml
initial revision: 1.1

/cvs/core/options/src/org/netbeans/api/options/OptionsDisplayer.java,v  <-- 
initial revision: 1.1

/cvs/core/options/nbproject/project.properties,v  <--  project.properties
new revision: 1.8; previous revision: 1.7

/cvs/core/options/nbproject/project.xml,v  <--  project.xml
new revision: 1.9; previous revision: 1.8

/cvs/ide/golden/public-packages.txt,v  <--  public-packages.txt
new revision: 1.78; previous revision: 1.77

/cvs/core/options/src/org/netbeans/modules/options/advanced/Model.java,v  <-- 
new revision: 1.14; previous revision: 1.13

/cvs/core/options/src/org/netbeans/modules/options/ui/TabbedPanel.java,v  <-- 
new revision: 1.8; previous revision: 1.7