This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 95974

Summary: Need non-FileObject-based VisibilityQuery.isVisible
Product: projects Reporter: Jesse Glick <jglick>
Component: Generic InfrastructureAssignee: Milos Kleint <mkleint>
Severity: blocker CC: pjiricka
Priority: P3 Keywords: API, API_REVIEW_FAST
Version: 6.x   
Hardware: All   
OS: All   
Issue Type: DEFECT Exception Reporter:
Bug Depends on:    
Bug Blocks: 44586, 49026    
Attachments: api change diff
includeexcludevisualizer patch
version control implements VisibilityQueryImplementation2

Description Jesse Glick 2007-02-19 22:51:48 UTC
Needed for efficient yet fully interoperable implementation of (see #49026).
In the meantime have to copy implementation from masterfs.
Comment 1 Milos Kleint 2007-02-23 07:52:19 UTC
jesse, is this critical for 6.0? I suppose not as it's a P3 -> future
Comment 2 Jesse Glick 2007-11-12 17:41:12 UTC
Please consider for 6.1. Should not be difficult.
Comment 3 Milos Kleint 2008-03-17 10:13:49 UTC
Created attachment 58468 [details]
api change diff
Comment 4 Milos Kleint 2008-03-17 10:18:31 UTC
please review.

the attached diff includes an additional spi interface VisibilityQueryImplementation2, additional method to
VisibilityQuery and an updated master fs implementation.

Users of the API shall not be required to call both VisibilityQuery.isVisible(FileObject) and isVisible(File). The
File-based method will attempt to delegate to the FileObject based one if the underlying VQI is not VQI2.
Comment 5 Jesse Glick 2008-03-17 17:59:48 UTC
Looks OK to me. Would be useful to include the patch to IncludeExcludeVisualizer which it would enable.
Comment 6 Milos Kleint 2008-03-20 15:01:59 UTC
Created attachment 58753 [details]
includeexcludevisualizer patch
Comment 7 Milos Kleint 2008-03-20 15:03:46 UTC
Created attachment 58754 [details]
version control implements VisibilityQueryImplementation2
Comment 8 Milos Kleint 2008-03-20 15:07:20 UTC
attached are the rewrite of IncludeExcludeVisualizer and also version control based VisbilityQueryImplementations now
implement the "2" interface.
Comment 9 Jesse Glick 2008-03-20 15:19:57 UTC
Looks good.
Comment 11 Milos Kleint 2008-03-21 09:48:51 UTC