This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 105135 - Component icon in project view is "hardcoded" and does not change depending on L&F used.
Summary: Component icon in project view is "hardcoded" and does not change depending o...
Status: RESOLVED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: visualweb (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Peter Zavadsky
URL:
Keywords: L&F
Depends on:
Blocks: 93821
  Show dependency tree
 
Reported: 2007-05-30 13:57 UTC by Ondrej Langr
Modified: 2008-09-03 17:36 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Folder icon inconsistency (41.02 KB, image/png)
2007-05-30 13:58 UTC, Ondrej Langr 		Details
component libraries badge (279 bytes, image/png)
2008-08-04 12:40 UTC, Ondrej Langr 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ondrej Langr 2007-05-30 13:57:22 UTC 
Component icon in project view is "hardcoded" and does not change depending on
which L&F is in use while other icons (source packages, configuration files,
etc.. ) are taken from the operating system. This icon should be changed so that
it is the same as with other nodes.
Comment 1 Ondrej Langr 2007-05-30 13:58:41 UTC 
Created attachment 42960 [details]
Folder icon inconsistency
Comment 2 Peter Zavadsky 2008-07-30 15:13:39 UTC 
The Component Libraries node is implemented in visualweb.complib. The other ones in web.project.

To achieve similar effect, the Component Libraries node would need to follow the other implementations, e.g.
ConfFilesNodeFactory$ConfFilesNode in web.project (see the code). I.e. instead of the entire icon, it would provide
specific component icon badge and merge it with the regular folder icon.

To fix this, the specific component icon badge is needed (CC'ing UI).
Comment 3 Ondrej Langr 2008-07-30 16:12:54 UTC 
I'm not sure I understand the problem, can you please clarify. There is a badge over the component libraries icon, IMO
it can be used with different underlying folder too .. correct?
Comment 4 Peter Zavadsky 2008-07-30 16:33:49 UTC 
Your observation is correct, unfortunately what you see is not a badge, but it is together with the yellow background
one entire icon, (the yellow background with the green spot)... it would be needed to have the green spot as a separate
image (to be used as a badge)
Comment 5 Ondrej Langr 2008-07-30 17:32:19 UTC 
Thanks for your explanation, now I see. I'll provide the badge, although it may take some time.
Comment 6 Ondrej Langr 2008-08-04 12:40:11 UTC 
Created attachment 66471 [details]
component libraries badge
Comment 7 Ondrej Langr 2008-08-04 12:40:40 UTC 
The badge is attached, assigning back.
Comment 8 _ edwingo 2008-08-04 16:37:40 UTC 
i no longer work on the project
Comment 9 Ondrej Langr 2008-08-04 16:58:53 UTC 
Dunno who to assign to. Peter?
Comment 10 Peter Zavadsky 2008-08-05 01:43:23 UTC 
I am on vacation now, and be back on August 25th. If it can't wait till then, please, reassign.
Comment 11 Peter Zavadsky 2008-09-02 21:58:32 UTC 
Fixed.

changeset:   99533:eddfe4d52dc4
tag:         tip
user:        Peter Zavadsky <pzavadsky@netbeans.org>
date:        Tue Sep 02 13:25:09 2008 -0700
summary:     #105135 Fixing icon badging of component libraries root node.
Comment 12 Quality Engineering 2008-09-03 17:36:44 UTC 
Integrated into 'main-golden', will be available in build *200809031401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/eddfe4d52dc4
User: Peter Zavadsky <pzavadsky@netbeans.org>
Log: #105135 Fixing icon badging of component libraries root node.