This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 106472 - API: ConnectionWidget class need to be restricted
Summary: API: ConnectionWidget class need to be restricted
Status: RESOLVED WONTFIX
Alias: None
Product: platform
Classification: Unclassified
Component: Graph (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: t_h
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks: 108754
  Show dependency tree
 
Reported: 2007-06-13 11:37 UTC by David Kaspar
Modified: 2009-07-02 05:25 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Patch (2.56 KB, patch)
2007-06-13 11:41 UTC, David Kaspar
Details | Diff
Second Patch (10.89 KB, patch)
2007-06-13 13:54 UTC, David Kaspar
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kaspar 2007-06-13 11:37:35 UTC
From the beginning the "ConnectionWidget.getTargetAnchorShapeRotation" method was meant to be private.
Comment 1 David Kaspar 2007-06-13 11:41:24 UTC
Created attachment 43609 [details]
Patch
Comment 2 David Kaspar 2007-06-13 13:54:08 UTC
Changing subjects since there are methods in ConnectionWidget which are possible to override but they were meant to be
"final".

Here is newly proposed change:
From beginning the ConnectionWidget.getTargetAnchorShapeRotation method was meant to be private. Also many getter and
setter methods in ConnectionWidget was meant to be final. It had been there by mistake, therefore:
1) getTargetAnchorShapeRotation was removed,
2) getSourceAnchorEntry, getTargetAnchorEntry, getSourceAnchorShape, setSourceAnchorShape, getTargetAnchorShape,
setTargetAnchorShape, getControlPointShape, setControlPointShape, getEndPointShape, setEndPointShape, getControlPoints,
getControlPoint, setControlPoints, setConstraint, setConstraint, removeConstraint methods of the ConnectionWidget class
were made "final".
Comment 3 David Kaspar 2007-06-13 13:54:26 UTC
Created attachment 43615 [details]
Second Patch
Comment 4 Jiri Prox 2007-09-17 20:26:08 UTC
Obsolete milestone, please reevaluate
Comment 5 t_h 2009-06-30 15:21:58 UTC
a27d86e433e7
Comment 6 t_h 2009-07-01 11:08:37 UTC
It was decided to avoid incompatible changes.
Comment 7 t_h 2009-07-01 11:10:58 UTC
Backed out in 5928dd47cc28
Comment 8 Quality Engineering 2009-07-02 05:25:56 UTC
Integrated into 'main-golden', will be available in build *200907020200* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/a27d86e433e7
User: Tomas Holy <t_h@netbeans.org>
Log: #106472: ConnectionWidget class need to be restricted